New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1808113: Fix OwnerReferences for bundled CRs #1341
Bug 1808113: Fix OwnerReferences for bundled CRs #1341
Conversation
Add a unit testcase to ensure custom resources created by InstallPlan execution are ownerrefed to the accompanying CSV only.
/hold |
@njhale: This pull request references Bugzilla bug 1808113, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@njhale: This pull request references Bugzilla bug 1808113, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @njhale - had a few nits but I think this can be merged quite quickly.
pkg/controller/operators/catalog/testdata/prometheusrule.cr.yaml
Outdated
Show resolved
Hide resolved
/retest |
/hold cancel |
/lgtm this only applies to the ownership of the new prometheus-related CRs right? No other effect on previous releases |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-4.4 |
@njhale: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@njhale: All pull requests linked via external trackers have merged. Bugzilla bug 1808113 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@njhale: new pull request created: #1351 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Fix InstallPlan execution to generate OwnerReferences on CRs applied to the respective CSV rather than the InstallPlan itself.
Motivation for the change:
Currently, bundled CRs are given OwnerReferences to the InstallPlan they were applied from, which is incorrect.