Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart to use the new "crds" directory. #1391

Merged

Conversation

benluddy
Copy link
Contributor

Helm 3 will handle CRD installation for CRD manifests located in the
chart's "crds" subdirectory, in exchange for dropping template
rendering support for CRD manifests. The only CRD template that exists
in the OLM chart today is used by a single test of downstream-only
behavior. The others are moved to "crds", and the release script has
been modified to look in both "templates" and "crds" for
manifests. The apiVersion in Chart.yaml has accordingly been bumped to
v2 to indicate that it requires Helm 3.

On its own, this change is intended to have minimal impact, but it's
part of the groundwork for bootstrapping E2E test environments for our
upstream CI.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@benluddy
Copy link
Contributor Author

/test unit

@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/test images

@benluddy
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2020
Helm 3 will handle CRD installation for CRD manifests located in the
chart's "crds" subdirectory, in exchange for dropping template
rendering support for CRD manifests. The only CRD template that exists
in the OLM chart today is used by a single test of downstream-only
behavior. The others are moved to "crds", and the release script has
been modified to look in both "templates" and "crds" for
manifests. The apiVersion in Chart.yaml has accordingly been bumped to
v2 to indicate that it requires Helm 3.

On its own, this change is intended to have minimal impact, but it's
part of the groundwork for bootstrapping E2E test environments for our
upstream CI.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2020
@benluddy
Copy link
Contributor Author

/test unit

@benluddy
Copy link
Contributor Author

/test e2e-aws-console-olm

@benluddy
Copy link
Contributor Author

/test e2e-gcp

@njhale
Copy link
Member

njhale commented Mar 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Contributor Author

/test e2e-gcp

@benluddy
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@benluddy
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
@benluddy
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@benluddy
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2dea823 into operator-framework:master Mar 20, 2020
awgreene pushed a commit to awgreene/operator-lifecycle-manager that referenced this pull request Mar 20, 2020
Update chart to use the new "crds" directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants