New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chart to use the new "crds" directory. #1391
Update chart to use the new "crds" directory. #1391
Conversation
/test unit |
/retest |
/test images |
/retest |
Helm 3 will handle CRD installation for CRD manifests located in the chart's "crds" subdirectory, in exchange for dropping template rendering support for CRD manifests. The only CRD template that exists in the OLM chart today is used by a single test of downstream-only behavior. The others are moved to "crds", and the release script has been modified to look in both "templates" and "crds" for manifests. The apiVersion in Chart.yaml has accordingly been bumped to v2 to indicate that it requires Helm 3. On its own, this change is intended to have minimal impact, but it's part of the groundwork for bootstrapping E2E test environments for our upstream CI.
/test unit |
/test e2e-aws-console-olm |
/test e2e-gcp |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Update chart to use the new "crds" directory.
Helm 3 will handle CRD installation for CRD manifests located in the
chart's "crds" subdirectory, in exchange for dropping template
rendering support for CRD manifests. The only CRD template that exists
in the OLM chart today is used by a single test of downstream-only
behavior. The others are moved to "crds", and the release script has
been modified to look in both "templates" and "crds" for
manifests. The apiVersion in Chart.yaml has accordingly been bumped to
v2 to indicate that it requires Helm 3.
On its own, this change is intended to have minimal impact, but it's
part of the groundwork for bootstrapping E2E test environments for our
upstream CI.