Unit test coverage reporting for gitlab #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ecordell
commented
Nov 3, 2017
ecordell
commented
- had to move code into /pkg to generate an accurate report
- added some more unit tests to get the coverage up a bit
|
You can see the badge here: |
ecordell
force-pushed
the
unit-tests
branch
3 times, most recently
from
449c956
to
63138b5
Compare
jakedt
reviewed
Nov 3, 2017
pkg/install/deployment.go
Outdated
| @@ -110,6 +110,10 @@ func (i *StrategyDeploymentInstaller) Install(s Strategy) error { | |||
| } | |||
| } | |||
|
|
|||
| //existingDeployments, err := i.strategyClient.GetOwnedDeployments(i.ownerMeta) | |||
There was a problem hiding this comment.
Remove this in a follow on PR please.
jakedt
approved these changes
Nov 3, 2017
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
Unit test coverage reporting for gitlab
ecordell
added a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Unit test coverage reporting for gitlab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.