New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upstream image build #1452
Fix upstream image build #1452
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d0cf8ab
to
fedc93d
Compare
.github/workflows/test-scripts.yml
Outdated
steps: | ||
- name: Check out the repo | ||
uses: actions/checkout@v2 | ||
- name: Push to Docker Hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind changing this step name since push is disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry -- will do!
/hold |
@njhale: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- Add a test to build the upstream OLM image - Trigger tests on changes to everything but docs - Change workflow name to "upstream-tests"
Include util dir in the upstream image build. Its absence was causing the build to fail.
/lgtm this is unheld to unblock the upstream e2e PR |
merging, infra-related, upstream-only and upstream tests are passing. |
Description of the change:
image-build
stage to the GitHub workflowMotivation for the change:
Upstream e2e tests fail because an olm image -- containing the
util/cpb
command -- hasn't successfully been built.