Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upstream image build #1452

Merged
merged 3 commits into from Apr 17, 2020
Merged

Fix upstream image build #1452

merged 3 commits into from Apr 17, 2020

Conversation

njhale
Copy link
Member

@njhale njhale commented Apr 16, 2020

Description of the change:

  • Fix the upstream image build by including the util directory
  • Add an image-build stage to the GitHub workflow

Motivation for the change:

Upstream e2e tests fail because an olm image -- containing the util/cpb command -- hasn't successfully been built.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@njhale njhale changed the title Fix image build Fix upstream image build Apr 16, 2020
@njhale njhale force-pushed the fix-image-build branch 2 times, most recently from d0cf8ab to fedc93d Compare April 16, 2020 20:33
@njhale njhale mentioned this pull request Apr 16, 2020
Closed
benluddy
benluddy reviewed Apr 16, 2020
View reviewed changes
.github/workflows/test-scripts.yml Outdated
steps:
- name: Check out the repo
uses: actions/checkout@v2
- name: Push to Docker Hub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind changing this step name since push is disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry -- will do!

@awgreene
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2020
@openshift-ci-robot
Copy link
Collaborator

@njhale: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade 71d9d0a link /test e2e-gcp-upgrade
ci/prow/e2e-gcp 71d9d0a link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale
test(gh-actions): add upstream image build test
686916d 
- Add a test to build the upstream OLM image
- Trigger tests on changes to everything but docs
- Change workflow name to "upstream-tests"
@njhale
fix(docker): include util dir in upstream image build
7bf6c4b 
Include util dir in the upstream image build. Its absence was causing
the build to fail.
@njhale
chore(gh-actions): install conntrack before minikube
e29e0a1
@ecordell
Copy link
Member

/lgtm
/hold cancel

this is unheld to unblock the upstream e2e PR

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@ecordell
Copy link
Member

merging, infra-related, upstream-only and upstream tests are passing.

@ecordell ecordell merged commit 83a1530 into operator-framework:master Apr 17, 2020
@njhale njhale deleted the fix-image-build branch July 23, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy benluddy left review comments

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

@exdx exdx Awaiting requested review from exdx

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@njhale @openshift-ci-robot @awgreene @ecordell @benluddy