Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate the chart embedded in the test installer as needed. #1454

Merged
merged 1 commit into from Apr 17, 2020
Merged

Regenerate the chart embedded in the test installer as needed. #1454

merged 1 commit into from Apr 17, 2020

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Apr 17, 2020 •
edited

For now, this should clear up any problems that can arise from testing
with a stale chart.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@benluddy
Regenerate the chart embedded in the test installer as needed.
02e67ba 
For now, this should clear up any problems that can arise from testing
with a stale chart.
@benluddy benluddy changed the title Regenerate the chart embedded in the test installer. Regenerate the chart embedded in the test installer as needed. Apr 17, 2020
ecordell
ecordell approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@openshift-ci-robot
Copy link
Collaborator

@benluddy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 02e67ba link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy benluddy merged commit f3f46c8 into operator-framework:master Apr 17, 2020
@benluddy
Copy link
Contributor Author

This change only affects upstream tests at the moment, so I'm fast-tracking it to unblock several other PRs.

@benluddy benluddy deleted the regenerate-test-chart branch April 17, 2020 14:41
@benluddy benluddy mentioned this pull request Jan 25, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@awgreene awgreene Awaiting requested review from awgreene

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benluddy @openshift-ci-robot @ecordell