Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing E2E bundle unpacking test. #1460

Merged
merged 1 commit into from Apr 18, 2020
Merged

Fix failing E2E bundle unpacking test. #1460

merged 1 commit into from Apr 18, 2020

Conversation

benluddy
Copy link
Contributor

The local E2E image didn't contain /bin/cp, which bundle unpacking
requires.

dinhxuanvu
dinhxuanvu reviewed Apr 17, 2020
View reviewed changes
e2e.Dockerfile Outdated Show resolved Hide resolved
@benluddy
Fix failing E2E bundle unpacking test.
5ef8fbb 
The local E2E image didn't contain /bin/cp, which bundle unpacking
requires.
@dinhxuanvu
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
ecordell
ecordell approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@dinhxuanvu
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Collaborator

@benluddy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 5ef8fbb link /test e2e-gcp
ci/prow/e2e-aws-olm 5ef8fbb link /test e2e-aws-olm
ci/prow/e2e-aws-console-olm 5ef8fbb link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell ecordell merged commit cd0626f into operator-framework:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@ecordell ecordell ecordell approved these changes

Assignees

@ecordell ecordell

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benluddy @dinhxuanvu @openshift-ci-robot @ecordell