Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1827822: Generation bug 4.3 #1485

Commits on Apr 25, 2020

  1. Fix Operator Generation code

    Problem:
    If an operator is being upgraded that provides a required API whose GVK
    has not changed since the previous version of the operator and
    uses a skipRange instead of the Spec.Replaces field, OLM will:
    * Add the new operator to the generation, and marking the APIs it
        provides as "present".
    * Remove the old operator from the generation, marking the APIs it
        provides as "absent", despite being provided by the new version of the
        operator.
    * Attempt to resolve the "missing" APIs, overwriting the new version
        of the operator with a copy that  does not have its Spec.Replaces field
        set.
    
    This causes OLM to fail the upgrade, where the old operator's CSV will
    not be replaced and the new operators CSV will run into an intercepting
    API Provider issue.
    
    Solution:
    Update OLM to remove the old operator from the current generation before
    adding the new operator to the generation.
    awgreene committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    1af7373 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. fix(resolver): Transferring API Ownership

    Problem:
    In an upgrade where v1 of Operator A provides an API and v1 of Operator
    B depends on the API, where the ownership of the API is transferred from
    Operator A to Operator B during the upgrade, OLM may run into a
    situation where Operator B is updated first. This causes OLM to fail to
    calculate the generation because multiple operator provide the same
    API.
    
    Solution:
    Add and remove updates as a set to prevent the situation described
    above.
    ecordell authored and awgreene committed May 5, 2020
    Configuration menu
    Copy the full SHA
    70a8441 View commit details
    Browse the repository at this point in the history