Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assertions for csv-e2e to use Gomega's matcher library #1507

Merged
merged 1 commit into from Nov 3, 2020
Merged

Replace assertions for csv-e2e to use Gomega's matcher library #1507

merged 1 commit into from Nov 3, 2020

Conversation

harishsurf
Copy link
Contributor

Description of the change:
This PR replaces testify/require assertions with Gomega's assertions. This PR will be followed up with another PR that uses ginkgo's Container blocks to ensure BDD style structuring

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@harishsurf harishsurf changed the title Replace assertions for csv-e2e to use Gomega's matcher library [WIP] Replace assertions for csv-e2e to use Gomega's matcher library May 8, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 8, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2020
@harishsurf harishsurf changed the title [WIP] Replace assertions for csv-e2e to use Gomega's matcher library Replace assertions for csv-e2e to use Gomega's matcher library May 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2020
benluddy
benluddy reviewed May 29, 2020
View reviewed changes
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
@harishsurf harishsurf force-pushed the csv-e2e branch 2 times, most recently from 4a51101 to 563c258 Compare June 4, 2020 20:03
@harishsurf
Copy link
Contributor Author

/retest

1 similar comment
@harishsurf
Copy link
Contributor Author

/retest

benluddy
benluddy requested changes Jun 24, 2020
View reviewed changes
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
@harishsurf harishsurf force-pushed the csv-e2e branch 2 times, most recently from 95a1093 to 95e0c78 Compare July 13, 2020 17:17
@harishsurf
Copy link
Contributor Author

/retest

1 similar comment
@harishsurf
Copy link
Contributor Author

/retest

benluddy
benluddy approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@benluddy benluddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks good. Would really like to see the "minikube" spec name fixed before merging so that no one else has to be as confused as I was.

test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/csv_e2e_test.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, harishsurf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@harishsurf harishsurf force-pushed the csv-e2e branch 2 times, most recently from 94e30fb to bb99c91 Compare August 25, 2020 14:51
@exdx
Copy link
Member

exdx commented Aug 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@exdx
Copy link
Member

exdx commented Aug 25, 2020

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@harishsurf
Copy link
Contributor Author

/retest

2 similar comments
@harishsurf
Copy link
Contributor Author

/retest

@harishsurf
Copy link
Contributor Author

/retest

@harishsurf
Copy link
Contributor Author

/test e2e-aws-olm

@harishsurf
Copy link
Contributor Author

/retest

@stale
Copy link

stale bot commented Oct 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 27, 2020
@harishsurf
Copy link
Contributor Author

/retest

@harishsurf
Copy link
Contributor Author

/test e2e-aws-olm

3 similar comments
@harishsurf
Copy link
Contributor Author

/test e2e-aws-olm

@harishsurf
Copy link
Contributor Author

/test e2e-aws-olm

@harishsurf
Copy link
Contributor Author

/test e2e-aws-olm

@exdx
Copy link
Member

exdx commented Nov 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d25a711 into operator-framework:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bowenislandsong Bowenislandsong Bowenislandsong left review comments

@benluddy benluddy benluddy approved these changes

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@harishsurf @openshift-ci-robot @exdx @openshift-bot @benluddy @Bowenislandsong @openshift-merge-robot