Bug 1833426: Update Webhook E2E Namespace Labels #1515
Conversation
Problem: An E2E test that ensures that Webhooks are scoped properly when the OperatorGroup uses a namespaceSelector fails because no namespaces are identified as a part of the OperatorGroup. Solution: Rather than update the Namespace to include the label, simply create the Namespace with the Label from the start.
|
/retest |
| nsCleanupFunc = func() { | ||
| err := c.KubernetesInterface().CoreV1().Namespaces().Delete(context.TODO(), namespace.GetName(), metav1.DeleteOptions{}) | ||
| Expect(err).Should(BeNil()) | ||
| } | ||
| }) | ||
| AfterEach(func() { | ||
| if nsCleanupFunc != nil { |
There was a problem hiding this comment.
It should not - but it prevents a potential nil pointer problem. It might be worth changing the if statement to Expect(nsCleanupFunc).ShouldNot(BeNil())
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
harishsurf
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@awgreene: This pull request references Bugzilla bug 1833426, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@awgreene: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1515. Bugzilla bug 1833426 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem:
An E2E test that ensures that Webhooks are scoped properly when the
OperatorGroup uses a namespaceSelector fails because no namespaces
are identified as a part of the OperatorGroup.
Solution:
Rather than update the Namespace to include the label, simply create
the Namespace with the Label from the start.