Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1846194: fix(package-server): get icons from default channel #1580

Merged
merged 1 commit into from Jul 29, 2020
Merged

[release-4.5] Bug 1846194: fix(package-server): get icons from default channel #1580

merged 1 commit into from Jul 29, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1579

/assign njhale

@njhale
fix(package-server): get icons from default channel
c85bfed 
Get icons from the default channel for icon subresource requests. Fixes
an issue which caused package-server to erroneously return icons from
the first channel declared.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2020
Merged
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: Bugzilla bug 1843652 has been cloned as Bugzilla bug 1846194. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1846194: fix(package-server): get icons from default channel

In response to this:

[release-4.5] Bug 1843652: fix(package-server): get icons from default channel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1843652: fix(package-server): get icons from default channel [release-4.5] Bug 1846194: fix(package-server): get icons from default channel Jun 11, 2020
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1846194, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1843652 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1843652 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1846194: fix(package-server): get icons from default channel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 11, 2020
@Bowenislandsong
Copy link
Member

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@njhale
Copy link
Member

njhale commented Jun 11, 2020

/hold until 4.5.z

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2020
@Bowenislandsong
Copy link
Member

/retest

@njhale
Copy link
Member

njhale commented Jul 16, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@njhale
Copy link
Member

njhale commented Jul 16, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 29, 2020
@sdodson
Copy link

sdodson commented Jul 29, 2020

/refresh

@openshift-merge-robot openshift-merge-robot merged commit c83c984 into operator-framework:release-4.5 Jul 29, 2020
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1580. Bugzilla bug 1846194 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1846194: fix(package-server): get icons from default channel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallettilance gallettilance Awaiting requested review from gallettilance

@njhale njhale Awaiting requested review from njhale

Assignees

@njhale njhale

@Bowenislandsong Bowenislandsong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @Bowenislandsong @njhale @sdodson @openshift-merge-robot