Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.5] Bug 1850619: don't store full manifests in installplan status (for bundle images) #1594

Commits on Jun 24, 2020

  1. fix(installplan): don't store the manifest contents on the installplan

    the installplan status.plan field stores a list of all manifests that
    will be installed when the installplan is approved.
    
    if the installplan is resolving a large set of dependencies, it is
    possible for it to exceed various limits in kube (grpc request size
    limit, etcd value size limit, etc).
    
    this commit changes the way objects are tracked if they come from
    bundle images. in that case, the manifests are already unpacked onto
    the cluster into a configmap. the installplan now stores a reference
    to the source configmap for each step, rather than storing the manifest
    itself. this allows the installplan to scale to a large number of
    resolved objects.
    ecordell authored and openshift-cherrypick-robot committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    eca0279 View commit details
    Browse the repository at this point in the history