Bug 1867169: Fix stale content in configmap due to stale bundle image in the node #1715
Conversation
If the bundle is already present in the node, during the unpack process the configmap may potentially use a stale bundle image. The default setting for ImagePullPolicy is `IfNotPresent` and should be changed to `Always`. Signed-off-by: Vu Dinh <vdinh@redhat.com>
dinhxuanvu
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@dinhxuanvu: This pull request references Bugzilla bug 1867169, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
This does potentially cause more egress from the cluster but the fix is necessary for the update feature to work correctly. |
|
/retest |
There was a problem hiding this comment.
Looks good @dinhxuanvu - one things I want to consider before I lgtm
| Command: []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount | ||
| Name: "pull", | ||
| Image: bundlePath, | ||
| ImagePullPolicy: "Always", |
There was a problem hiding this comment.
Should we be worried about the consequences of pulling an image in a bundle everytime an operator is deployed? If operators are installed in multiple namespaces this is expensive.
There was a problem hiding this comment.
Yes, this is essentially the tradeoff
There was a problem hiding this comment.
I don't think this is such a big deal given the bundle image is just scratch image so it is small. Plus, unless there are multiple new installations of the same operator in multiple namespaces (that is different with MultiNamespace mode), then this scenario doesn't happen. The common pattern of operator installation so far has been pretty much singleton.
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@dinhxuanvu: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1715. Bugzilla bug 1867169 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@dinhxuanvu: new pull request created: #1724 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If the bundle is already present in the node, during the unpack process
the configmap may potentially use a stale bundle image. The default
setting for ImagePullPolicy is
IfNotPresentand should be changed toAlways.Signed-off-by: Vu Dinh vdinh@redhat.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs