Bug 1867802: shorten catalog sync interval if polling is enabled #1731

exdx · 2020-08-20T18:06:34Z

Description of the change:
Requeues the catalog source sync if polling is set and less than the default (15 minutes). This enables shorter polling intervals to be more accurately reconciled by OLM.

Motivation for the change:
OLM allows users to set an arbitrary catalog polling interval to check a registry to see if the catalog image has changed. In theory, it should respect this time.Duration, but due to the nature of the OLM sync cycle the polling occurs every OLM namespace sync, ie every 15 minutes.

Therefore sync cycles less than 15 minutes don't work as intended, and in general the sync cycles are skewed by OLM's own sync cycle.

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci-robot · 2020-08-20T18:06:40Z

@exdx: This pull request references Bugzilla bug 1867802, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1867802: shorten catalog sync interval if polling is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu

/lgtm

pkg/controller/operators/catalog/operator.go

of-deploy-bot · 2020-08-31T19:16:43Z

This PR failed 2 out of 2 times with 4 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 2
failedtestcount: 2
flaketestcount: 4
skippedtestcount: 4
flaketests:

classname: End-to-end
name: 'Install Plan with CSVs across multiple catalog sources'
counts: 3
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:45
Resource does not match expected value:   &v1alpha1.InstallPlan{
  	TypeMeta: {},
  	ObjectMeta: v1.ObjectMeta{
  		... // 3 identical fields
  		SelfLink:                   "/apis/operators.coreos.com/v1alpha1/namespaces/operators/install"...,
  		UID:                        "2431db01-61fe-4abf-b415-b45da3abcabb",
- 		ResourceVersion:            "14923",
+ 		ResourceVersion:            "14930",
  		Generation:                 1,
  		CreationTimestamp:          {Time: s"2020-08-31 18:50:00 +0000 UTC"},
  		DeletionTimestamp:          nil,
  		DeletionGracePeriodSeconds: nil,
  		Labels: map[string]string{
  			"operators.coreos.com/nginx-mswxg.operators":    "",
+ 			"operators.coreos.com/nginxdep-fgbbc.operators": "",
  		},
  		Annotations:     nil,
  		OwnerReferences: {{APIVersion: "operators.coreos.com/v1alpha1", Kind: "Subscription", Name: "sub-nginx-xlx69", UID: "39d25690-88fa-4a99-bfe9-04610aeb1ca5", ...}},
  		... // 3 identical fields
  	},
  	Spec:   {ClusterServiceVersionNames: {"nginxdep-fgbbc-stable", "nginx-mswxg-stable"}, Approval: "Automatic", Approved: true, Generation: 1},
  	Status: {Phase: "Complete", Conditions: {{Type: "Installed", Status: "True", LastUpdateTime: s"2020-08-31 18:50:01 +0000 UTC", LastTransitionTime: s"2020-08-31 18:50:01 +0000 UTC", ...}}, CatalogSources: {"mock-ocs-dependent-h758d", "mock-ocs-main-4s4nt"}, Plan: {&{Resolving: "nginxdep-fgbbc-stable", Resource: {CatalogSource: "mock-ocs-dependent-h758d", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginx-mswxg-stable", Resource: {CatalogSource: "mock-ocs-main-4s4nt", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginxdep-fgbbc-stable", Resource: {CatalogSource: "mock-ocs-dependent-h758d", CatalogSourceNamespace: "operators", Group: "apiextensions.k8s.io", Version: "v1beta1", ...}, Status: "Present"}, &{Resolving: "nginxdep-fgbbc-stable", Resource: {CatalogSource: "mock-ocs-dependent-h758d", CatalogSourceNamespace: "operators", Group: "operators.coreos.com", Version: "v1alpha1", ...}, Status: "Present"}}, ...},
  }

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:2700

meandurationsec: 153.91357466666665

classname: End-to-end
name: 'Subscription to an operator with dependencies from different CatalogSources
with priorities creating CatalogSources providing the same dependency with
different names when creating subscription for the main package choose the
dependency from the right CatalogSource based on lexicographical name ordering
of catalogs'
counts: 2
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:51
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:2, cap:2>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-main",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-main",
                UID: "64ef90a4-953f-456d-9e7f-b7119b8bcfd6",
                ResourceVersion: "11828",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-08-31T18:40:58Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.d0b15562e899f976": "required",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "dephlkg8",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: nil,
                    Required: [
                        {
                            Name: "insh6xpx.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insh6xpx",
                            DisplayName: "insh6xpx.cluster.com",
                            Description: "insh6xpx.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-08-31T18:41:04Z,
                },
                LastTransitionTime: {
                    Time: 2020-08-31T18:41:04Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:40:58Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:40:58Z,
                        },
                    },
                    {
                        Phase: "Pending",
                        Message: "one or more requirements couldn't be found",
                        Reason: "RequirementsNotMet",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:40:58Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment dephlkg8 to become ready: Waiting for deployment spec update to be observed...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:02Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:04Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:04Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-main",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insh6xpx.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "3f96d4b4-fea9-45b3-9ca4-8e8a6180a310",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "csv-right",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/csv-right",
                UID: "75862d67-e2df-456c-a42b-e62529460bbd",
                ResourceVersion: "11843",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-08-31T18:40:58Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: {
                    "olm.api.d0b15562e899f976": "provided",
                },
                Annotations: {
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "depcxw6m",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 0, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {
                    Owned: [
                        {
                            Name: "insh6xpx.cluster.com",
                            Version: "v1alpha1",
                            Kind: "insh6xpx",
                            DisplayName: "insh6xpx.cluster.com",
                            Description: "insh6xpx.cluster.com",
                            Resources: nil,
                            StatusDescriptors: nil,
                            SpecDescriptors: nil,
                            ActionDescriptor: nil,
                        },
                    ],
                    Required: nil,
                },
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "0.0.0",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-08-31T18:41:04Z,
                },
                LastTransitionTime: {
                    Time: 2020-08-31T18:41:04Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment depcxw6m to become ready: Waiting for deployment spec update to be observed...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:01Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:00Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-08-31T18:41:04Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-08-31T18:41:04Z,
                        },
                    },
                ],
                RequirementStatus: [
                    {
                        Group: "operators.coreos.com",
                        Version: "v1alpha1",
                        Kind: "ClusterServiceVersion",
                        Name: "csv-right",
                        Status: "Present",
                        Message: "CSV minKubeVersion (0.0.0) less than server version (v1.17.0)",
                        UUID: "",
                        Dependents: nil,
                    },
                    {
                        Group: "apiextensions.k8s.io",
                        Version: "v1",
                        Kind: "CustomResourceDefinition",
                        Name: "insh6xpx.cluster.com",
                        Status: "Present",
                        Message: "CRD is present and Established condition is true",
                        UUID: "3f96d4b4-fea9-45b3-9ca4-8e8a6180a310",
                        Dependents: nil,
                    },
                ],
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 82.808629

classname: End-to-end
name: 'Install Plan with CRD schema change Test existing version is present
in new CRD (deprecated field)'
counts: 1
details:
- count: 1
  error: "\n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:43\n\n\tError
  Trace:\tinstallplan_e2e_test.go:765\n\t \t\t\t\tvalue.go:460\n\t
  \ \t\t\t\tvalue.go:321\n\t \t\t\t\ttable_entry.go:37\n\t
  \ \t\t\t\trunner.go:113\n\t \t\t\t\trunner.go:64\n\t
  \ \t\t\t\tit_node.go:26\n\t \t\t\t\tspec.go:215\n\t
  \ \t\t\t\tspec.go:138\n\t \t\t\t\tspec_runner.go:200\n\t
  \ \t\t\t\tspec_runner.go:170\n\t \t\t\t\tspec_runner.go:66\n\t
  \ \t\t\t\tsuite.go:62\n\t \t\t\t\tginkgo_dsl.go:226\n\t
  \ \t\t\t\tginkgo_dsl.go:214\n\t \t\t\t\te2e_test.go:54\n\tError:
  \ \tNot equal: \n\t \texpected: "Complete"\n\t \tactual
  \ : "Failed"\n\t \t\n\t \tDiff:\n\t \t---
  Expected\n\t \t+++ Actual\n\t \t@@ -1,2 +1,2 @@\n\t
  \ \t-(v1alpha1.InstallPlanPhase) (len=8) "Complete"\n\t \t+(v1alpha1.InstallPlanPhase)
  (len=6) "Failed"\n\t \t \n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:162"
  meandurationsec: 26.323886

classname: End-to-end
name: 'Install Plan creation with pre existing CRD owners PreExistingCRDOwnerIsReplaced'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:325

	Error Trace:	installplan_e2e_test.go:434
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	timed out waiting for the condition

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005

meandurationsec: 337.390941
skippedtests:

classname: End-to-end
name: 'Subscription updates existing install plan'
counts: 2
details: []
meandurationsec: 0.28381850000000003
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should install the operator
successfully'
counts: 2
details: []
meandurationsec: 15.841593999999999
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should have created the expected
prometheus objects'
counts: 2
details: []
meandurationsec: 19.149946999999997
classname: End-to-end
name: 'Catalog image update'
counts: 2
details: []
meandurationsec: 0.13576549999999998

dinhxuanvu

Looking good. Just a small comment.

pkg/controller/registry/reconciler/grpc_polling.go

dinhxuanvu

/lgtm

exdx · 2020-09-03T19:04:18Z

/retest

ecordell · 2020-09-04T16:57:05Z

/approve

well written, well documented, well tested 👍

openshift-ci-robot · 2020-09-04T16:57:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-04T17:01:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-04T20:42:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-04T20:55:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

exdx · 2020-09-05T00:18:32Z

/hold

openshift-bot · 2020-09-08T20:53:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T00:46:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T04:27:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T04:41:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T07:55:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T09:39:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-09T13:20:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

exdx · 2020-09-09T14:53:53Z

/hold

exdx · 2020-09-10T13:50:09Z

/hold cancel
/retest

openshift-bot · 2020-09-10T14:55:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

exdx · 2020-09-10T19:47:02Z

/retest

openshift-bot · 2020-09-10T22:30:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-10T22:44:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-10T22:55:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-11T00:01:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

exdx · 2020-09-11T01:06:20Z

/test e2e-upgrade

openshift-bot · 2020-09-11T11:55:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-11T12:08:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

exdx · 2020-09-11T14:42:22Z

/retest

exdx · 2020-09-11T15:04:26Z

/retest

openshift-bot · 2020-09-11T16:02:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

exdx · 2020-09-11T20:04:39Z

/cherry-pick release-4.5

openshift-cherrypick-robot · 2020-09-11T20:04:40Z

@exdx: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-11T20:53:09Z

@exdx: All pull requests linked via external trackers have merged:

operator-framework/operator-lifecycle-manager#1731

Bugzilla bug 1867802 has been moved to the MODIFIED state.

In response to this:

Bug 1867802: shorten catalog sync interval if polling is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-09-11T20:53:13Z

@exdx: new pull request created: #1759

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fix: resync catalogs with jitter if polling enabled

ed8a487

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 20, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 20, 2020

openshift-ci-robot requested review from awgreene and benluddy August 20, 2020 18:06

exdx requested review from ecordell and dinhxuanvu August 20, 2020 18:06

dinhxuanvu approved these changes Aug 21, 2020

View reviewed changes

openshift-ci-robot assigned dinhxuanvu Aug 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020

ecordell reviewed Aug 21, 2020

View reviewed changes

pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020

exdx requested review from dinhxuanvu and ecordell September 1, 2020 14:15

dinhxuanvu requested changes Sep 2, 2020

View reviewed changes

pkg/controller/registry/reconciler/grpc_polling.go Outdated Show resolved Hide resolved

add correct polling interval based on modulus

1bc18c5

exdx force-pushed the fix/catalog-sync branch from 946ee73 to 1bc18c5 Compare September 3, 2020 15:58

exdx requested a review from dinhxuanvu September 3, 2020 15:58

dinhxuanvu approved these changes Sep 3, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2020

openshift-merge-robot merged commit 19bdd53 into operator-framework:master Sep 11, 2020

openshift-cherrypick-robot mentioned this pull request Sep 11, 2020

[release-4.5] Bug 1878307: shorten catalog sync interval if polling is enabled #1759

Closed

Bug 1867802: shorten catalog sync interval if polling is enabled #1731

Bug 1867802: shorten catalog sync interval if polling is enabled #1731

Conversation

exdx commented Aug 20, 2020

openshift-ci-robot commented Aug 20, 2020

dinhxuanvu left a comment

Choose a reason for hiding this comment

of-deploy-bot commented Aug 31, 2020

dinhxuanvu left a comment

Choose a reason for hiding this comment

dinhxuanvu left a comment

Choose a reason for hiding this comment

exdx commented Sep 3, 2020

ecordell commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020

openshift-bot commented Sep 4, 2020

openshift-bot commented Sep 4, 2020

openshift-bot commented Sep 4, 2020

exdx commented Sep 5, 2020

openshift-bot commented Sep 8, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

openshift-bot commented Sep 9, 2020

exdx commented Sep 9, 2020

exdx commented Sep 10, 2020

openshift-bot commented Sep 10, 2020

exdx commented Sep 10, 2020

openshift-bot commented Sep 10, 2020

openshift-bot commented Sep 10, 2020

openshift-bot commented Sep 10, 2020

openshift-bot commented Sep 11, 2020

exdx commented Sep 11, 2020

openshift-bot commented Sep 11, 2020

openshift-bot commented Sep 11, 2020

exdx commented Sep 11, 2020

exdx commented Sep 11, 2020

openshift-bot commented Sep 11, 2020

exdx commented Sep 11, 2020

openshift-cherrypick-robot commented Sep 11, 2020

openshift-ci-robot commented Sep 11, 2020

openshift-cherrypick-robot commented Sep 11, 2020