Bug 1885398: Retrieve CA from conversion webhooks for CA Hash #1797
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
awgreene
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@awgreene: This pull request references Bugzilla bug 1885398, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
awgreene
force-pushed
the
retrieve-ca-from-cw
branch
from
4889b2f
to
9e47ce7
Compare
awgreene
force-pushed
the
retrieve-ca-from-cw
branch
2 times, most recently
from
acceab0
to
223fe0d
Compare
Problem: If a CSV defines a Conversion Webhook but does not include an API Service or an Admission Webhook the CSV will cycle through the Pending, ReadyToInstall, and Installing phases indefinitely. Cause: When deploying an operator with an API Service, Conversion Webhook, or an Admission Webhook, OLM should retrieve the CA from an existing resource in order to calculate a CA Hash annotation. This annotation influences a Deployment Hash that OLM relies on to confirm that the deployment is installed correctly. OLM currently does not retrieve the CA from Conversion Webhooks, resulting in a bad Deployment Hash which causes OLM to attempt to reinstall the CSV. Solution: Update OLM so it will use the existing Conversion Webhook to retrieve that value of the CA and correctly calculate the Deployment Hash.
awgreene
force-pushed
the
retrieve-ca-from-cw
branch
from
223fe0d
to
55c630c
Compare
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@awgreene: All pull requests linked via external trackers have merged: Bugzilla bug 1885398 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@awgreene: new pull request created: #1802 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: If a CSV defines a Conversion Webhook but does not include an
API Service or an Admission Webhook the CSV will cycle through the
Pending, ReadyToInstall, and Installing phases indefinitely.
Cause: When deploying an operator with an API Service, Conversion
Webhook, or an Admission Webhook, OLM should retrieve the CA from an
existing resource in order to calculate a CA Hash annotation. This
annotation influences a Deployment Hash that OLM relies on to confirm
that the deployment is installed correctly. OLM currently does not
retrieve the CA from Conversion Webhooks, resulting in a bad
Deployment Hash which causes OLM to attempt to reinstall the CSV.
Solution: Update OLM so it will use the existing Conversion Webhook to
retrieve that value of the CA and correctly calculate the Deployment
Hash.