Bug 1891898: Set default, min, and max values on Webhook ports #1835

awgreene · 2020-10-27T17:47:35Z

Problem: Operator Authors can create CSVs that define Webhooks with
containerPorts set outside the range of 1-65535, which prevents the
ValidatingWebhookConfiguration or MutatingWebhookConfiguration from
being created due to failed validation.

Solution: Update the CSV's CRD Validation to include the proper min and
max values for webhookDescription ContainerPort field. If the
containerPort is not defined, default to 443.

openshift-ci-robot · 2020-10-27T17:47:42Z

@awgreene: This pull request references Bugzilla bug 1891898, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1891898: Set default, min, and max values on Webhook ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-27T17:49:56Z

@awgreene: This pull request references Bugzilla bug 1891898, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1891898: Set default, min, and max values on Webhook ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-10-27T17:53:34Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2020-10-27T17:53:35Z

@awgreene: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

of-deploy-bot · 2020-10-27T18:43:25Z

This PR failed 1 out of 1 times with 4 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
failedtestcount: 1
flaketestcount: 4
skippedtestcount: 4
flaketests:

classname: End-to-end
name: 'Subscription creation if not installed'
counts: 3
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:53
Timed out after 60.001s.
failed to await deletion of test csvs
Expected
    <[]v1alpha1.ClusterServiceVersion | len:1, cap:1>: [
        {
            TypeMeta: {
                Kind: "ClusterServiceVersion",
                APIVersion: "operators.coreos.com/v1alpha1",
            },
            ObjectMeta: {
                Name: "myapp-beta",
                GenerateName: "",
                Namespace: "operators",
                SelfLink: "/apis/operators.coreos.com/v1alpha1/namespaces/operators/clusterserviceversions/myapp-beta",
                UID: "fdb5938a-a8e8-482c-8098-a7944164ecb4",
                ResourceVersion: "21534",
                Generation: 1,
                CreationTimestamp: {
                    Time: 2020-10-27T18:25:10Z,
                },
                DeletionTimestamp: nil,
                DeletionGracePeriodSeconds: nil,
                Labels: nil,
                Annotations: {
                    "operatorframework.io/properties": "{\"properties\":[{\"type\":\"olm.package\",\"value\":{\"packageName\":\"myapp\",\"version\":\"0.1.1\"}}]}",
                    "olm.operatorGroup": "global-operators",
                    "olm.operatorNamespace": "operators",
                    "olm.targetNamespaces": "",
                },
                OwnerReferences: nil,
                Finalizers: nil,
                ClusterName: "",
                ManagedFields: nil,
            },
            Spec: {
                InstallStrategy: {
                    StrategyName: "deployment",
                    StrategySpec: {
                        DeploymentSpecs: [
                            {
                                Name: "dep-f8twv",
                                Spec: {
                                    Replicas: 1,
                                    Selector: {
                                        MatchLabels: {...: ...},
                                        MatchExpressions: nil,
                                    },
                                    Template: {
                                        ObjectMeta: {
                                            Name: ...,
                                            GenerateName: ...,
                                            Namespace: ...,
                                            SelfLink: ...,
                                            UID: ...,
                                            ResourceVersion: ...,
                                            Generation: ...,
                                            CreationTimestamp: ...,
                                            DeletionTimestamp: ...,
                                            DeletionGracePeriodSeconds: ...,
                                            Labels: ...,
                                            Annotations: ...,
                                            OwnerReferences: ...,
                                            Finalizers: ...,
                                            ClusterName: ...,
                                            ManagedFields: ...,
                                        },
                                        Spec: {
                                            Volumes: ...,
                                            InitContainers: ...,
                                            Containers: ...,
                                            EphemeralContainers: ...,
                                            RestartPolicy: ...,
                                            TerminationGracePeriodSeconds: ...,
                                            ActiveDeadlineSeconds: ...,
                                            DNSPolicy: ...,
                                            NodeSelector: ...,
                                            ServiceAccountName: ...,
                                            DeprecatedServiceAccount: ...,
                                            AutomountServiceAccountToken: ...,
                                            NodeName: ...,
                                            HostNetwork: ...,
                                            HostPID: ...,
                                            HostIPC: ...,
                                            ShareProcessNamespace: ...,
                                            SecurityContext: ...,
                                            ImagePullSecrets: ...,
                                            Hostname: ...,
                                            Subdomain: ...,
                                            Affinity: ...,
                                            SchedulerName: ...,
                                            Tolerations: ...,
                                            HostAliases: ...,
                                            PriorityClassName: ...,
                                            Priority: ...,
                                            DNSConfig: ...,
                                            ReadinessGates: ...,
                                            RuntimeClassName: ...,
                                            EnableServiceLinks: ...,
                                            PreemptionPolicy: ...,
                                            Overhead: ...,
                                            TopologySpreadConstraints: ...,
                                        },
                                    },
                                    Strategy: {Type: "", RollingUpdate: nil},
                                    MinReadySeconds: 0,
                                    RevisionHistoryLimit: nil,
                                    Paused: false,
                                    ProgressDeadlineSeconds: nil,
                                },
                                Label: nil,
                            },
                        ],
                        Permissions: nil,
                        ClusterPermissions: nil,
                    },
                },
                Version: {
                    Version: {Major: 0, Minor: 1, Patch: 1, Pre: nil, Build: nil},
                },
                Maturity: "",
                CustomResourceDefinitions: {Owned: nil, Required: nil},
                APIServiceDefinitions: {Owned: nil, Required: nil},
                WebhookDefinitions: nil,
                NativeAPIs: nil,
                MinKubeVersion: "",
                DisplayName: "",
                Description: "",
                Keywords: nil,
                Maintainers: nil,
                Provider: {Name: "", URL: ""},
                Links: nil,
                Icon: nil,
                InstallModes: [
                    {Type: "OwnNamespace", Supported: true},
                    {
                        Type: "SingleNamespace",
                        Supported: true,
                    },
                    {
                        Type: "MultiNamespace",
                        Supported: true,
                    },
                    {
                        Type: "AllNamespaces",
                        Supported: true,
                    },
                ],
                Replaces: "myapp-stable",
                Labels: nil,
                Annotations: nil,
                Selector: nil,
            },
            Status: {
                Phase: "Succeeded",
                Message: "install strategy completed with no errors",
                Reason: "InstallSucceeded",
                LastUpdateTime: {
                    Time: 2020-10-27T18:25:11Z,
                },
                LastTransitionTime: {
                    Time: 2020-10-27T18:25:11Z,
                },
                Conditions: [
                    {
                        Phase: "Pending",
                        Message: "requirements not yet checked",
                        Reason: "RequirementsUnknown",
                        LastUpdateTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                    },
                    {
                        Phase: "InstallReady",
                        Message: "all requirements found, attempting install",
                        Reason: "AllRequirementsMet",
                        LastUpdateTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "waiting for install components to report healthy",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                    },
                    {
                        Phase: "Installing",
                        Message: "installing: waiting for deployment dep-f8twv to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                        Reason: "InstallWaiting",
                        LastUpdateTime: {
                            Time: 2020-10-27T18:25:11Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T18:25:10Z,
                        },
                    },
                    {
                        Phase: "Succeeded",
                        Message: "install strategy completed with no errors",
                        Reason: "InstallSucceeded",
                        LastUpdateTime: {
                            Time: 2020-10-27T18:25:11Z,
                        },
                        LastTransitionTime: {
                            Time: 2020-10-27T18:25:11Z,
                        },
                    },
                ],
                RequirementStatus: nil,
                CertsLastUpdated: nil,
                CertsRotateAt: nil,
            },
        },
    ]
to be empty
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/util_test.go:496

meandurationsec: 140.138745

classname: End-to-end
name: 'Install Plan with CRD schema change Test all existing versions are present,
different (backwards compatible) schema'
counts: 1
details:
- count: 1
  error: "\n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:43\n\n\tError
  Trace:\tinstallplan_e2e_test.go:769\n\t \t\t\t\tvalue.go:460\n\t
  \ \t\t\t\tvalue.go:321\n\t \t\t\t\ttable_entry.go:37\n\t
  \ \t\t\t\trunner.go:113\n\t \t\t\t\trunner.go:64\n\t
  \ \t\t\t\tit_node.go:26\n\t \t\t\t\tspec.go:215\n\t
  \ \t\t\t\tspec.go:138\n\t \t\t\t\tspec_runner.go:200\n\t
  \ \t\t\t\tspec_runner.go:170\n\t \t\t\t\tspec_runner.go:66\n\t
  \ \t\t\t\tsuite.go:62\n\t \t\t\t\tginkgo_dsl.go:226\n\t
  \ \t\t\t\tginkgo_dsl.go:214\n\t \t\t\t\te2e_test.go:54\n\tError:
  \ \tNot equal: \n\t \texpected: "Complete"\n\t \tactual
  \ : "Failed"\n\t \t\n\t \tDiff:\n\t \t---
  Expected\n\t \t+++ Actual\n\t \t@@ -1,2 +1,2 @@\n\t
  \ \t-(v1alpha1.InstallPlanPhase) (len=8) "Complete"\n\t \t+(v1alpha1.InstallPlanPhase)
  (len=6) "Failed"\n\t \t \n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:162"
  meandurationsec: 32.759785

classname: End-to-end
name: 'Installing bundles with new object types when a bundle with a pdb, priorityclass,
and VPA object is installed should create the additional bundle objects'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/bundle_e2e_test.go:50
could not get subscription at latest status
Unexpected error:
    <*errors.errorString | 0xc0001f6290>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/bundle_e2e_test.go:113

meandurationsec: 301.211566

classname: End-to-end
name: 'Catalog Dependency has correct replaces field'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go:879

	Error Trace:	catalog_e2e_test.go:924
	            				runner.go:113
	            				runner.go:64
	            				it_node.go:26
	            				spec.go:215
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	timed out waiting for the condition

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005

meandurationsec: 300.120163
skippedtests:

classname: End-to-end
name: 'Catalog image update'
counts: 1
details: []
meandurationsec: 0.034105
classname: End-to-end
name: 'Subscription updates existing install plan'
counts: 1
details: []
meandurationsec: 0.031523
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should have created the expected
prometheus objects'
counts: 1
details: []
meandurationsec: 15.179425
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should install the operator
successfully'
counts: 1
details: []
meandurationsec: 14.152761

dinhxuanvu

/lgtm

openshift-ci-robot · 2020-10-27T20:07:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Problem: Operator Authors can create CSVs that define Webhooks with containerPorts set outside the range of 1-65535, which prevents the ValidatingWebhookConfiguration or MutatingWebhookConfiguration from being created due to failed validation. Solution: Update the CSV's CRD Validation to include the proper min and max values for webhookDescription ContainerPort field. If the containerPort is not defined, default to 443.

benluddy · 2020-10-27T20:13:42Z

/lgtm

of-deploy-bot · 2020-10-27T21:22:14Z

This PR failed 1 out of 1 times with 4 individual failed tests and 4 skipped tests. A test is considered flaky if failed on multiple commits.

totaltestcount: 1
failedtestcount: 1
flaketestcount: 4
skippedtestcount: 4
flaketests:

classname: End-to-end
name: 'CSVs with a Webhook when Installed from a catalog Source Validating,
Mutating and Conversion webhooks work as intended'
counts: 3
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/webhook_e2e_test.go:633

	Error Trace:	webhook_e2e_test.go:672
	            				runner.go:113
	            				runner.go:64
	            				setup_nodes.go:15
	            				spec.go:193
	            				spec.go:138
	            				spec_runner.go:200
	            				spec_runner.go:170
	            				spec_runner.go:66
	            				suite.go:62
	            				ginkgo_dsl.go:226
	            				ginkgo_dsl.go:214
	            				e2e_test.go:54
	Error:      	Received unexpected error:
	            	timed out waiting for the condition

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1005

meandurationsec: 300.07028833333334

classname: End-to-end
name: 'CRD Versions allows a CRD upgrade that doesn''t cause data loss'
counts: 2
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:345
Unexpected error:
    <*errors.errorString | 0xc0001702b0>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:495

meandurationsec: 218.44151749999997

classname: End-to-end
name: 'Install Plan with CSVs across multiple catalog sources'
counts: 1
details:

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:49
Resource does not match expected value:   &v1alpha1.InstallPlan{
  	TypeMeta: {},
  	ObjectMeta: v1.ObjectMeta{
  		... // 3 identical fields
  		SelfLink:                   "/apis/operators.coreos.com/v1alpha1/namespaces/operators/install"...,
  		UID:                        "47c659fc-47a3-4968-9c77-fc29e5a34611",
- 		ResourceVersion:            "2915",
+ 		ResourceVersion:            "2922",
  		Generation:                 1,
  		CreationTimestamp:          {Time: s"2020-10-27 20:23:32 +0000 UTC"},
  		DeletionTimestamp:          nil,
  		DeletionGracePeriodSeconds: nil,
  		Labels: map[string]string{
  			"operators.coreos.com/nginx-vbrxg.operators":    "",
+ 			"operators.coreos.com/nginxdep-nzlf6.operators": "",
  		},
  		Annotations:     nil,
  		OwnerReferences: {{APIVersion: "operators.coreos.com/v1alpha1", Kind: "Subscription", Name: "sub-nginx-9q6t2", UID: "26b989c7-4df2-4708-a612-7429793d886d", ...}},
  		... // 3 identical fields
  	},
  	Spec:   {ClusterServiceVersionNames: {"nginxdep-nzlf6-stable", "nginx-vbrxg-stable"}, Approval: "Automatic", Approved: true, Generation: 1},
  	Status: {Phase: "Complete", Conditions: {{Type: "Installed", Status: "True", LastUpdateTime: s"2020-10-27 20:23:36 +0000 UTC", LastTransitionTime: s"2020-10-27 20:23:36 +0000 UTC", ...}}, CatalogSources: {"mock-ocs-dependent-mbnrj", "mock-ocs-main-8lwtl"}, Plan: {&{Resolving: "nginxdep-nzlf6-stable", Resource: {CatalogSource: "mock-ocs-dependent-mbnrj", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginx-vbrxg-stable", Resource: {CatalogSource: "mock-ocs-main-8lwtl", CatalogSourceNamespace: "operators", Version: "v1alpha1", Kind: "ClusterServiceVersion", ...}, Status: "Present"}, &{Resolving: "nginxdep-nzlf6-stable", Resource: {CatalogSource: "mock-ocs-dependent-mbnrj", CatalogSourceNamespace: "operators", Group: "apiextensions.k8s.io", Version: "v1beta1", ...}, Status: "Present"}, &{Resolving: "nginxdep-nzlf6-stable", Resource: {CatalogSource: "mock-ocs-dependent-mbnrj", CatalogSourceNamespace: "operators", Group: "operators.coreos.com", Version: "v1alpha1", ...}, Status: "Present"}}, ...},
  }

/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:2792

meandurationsec: 38.309635

classname: End-to-end
name: 'Install Plan with CRD schema change Test all existing versions are present,
different (backwards incompatible) schema'
counts: 1
details:
- count: 1
  error: "\n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/onsi/ginkgo/extensions/table/table_entry.go:43\n\n\tError
  Trace:\tinstallplan_e2e_test.go:769\n\t \t\t\t\tvalue.go:460\n\t
  \ \t\t\t\tvalue.go:321\n\t \t\t\t\ttable_entry.go:37\n\t
  \ \t\t\t\trunner.go:113\n\t \t\t\t\trunner.go:64\n\t
  \ \t\t\t\tit_node.go:26\n\t \t\t\t\tspec.go:215\n\t
  \ \t\t\t\tspec.go:138\n\t \t\t\t\tspec_runner.go:200\n\t
  \ \t\t\t\tspec_runner.go:170\n\t \t\t\t\tspec_runner.go:66\n\t
  \ \t\t\t\tsuite.go:62\n\t \t\t\t\tginkgo_dsl.go:226\n\t
  \ \t\t\t\tginkgo_dsl.go:214\n\t \t\t\t\te2e_test.go:54\n\tError:
  \ \tNot equal: \n\t \texpected: "Complete"\n\t \tactual
  \ : "Failed"\n\t \t\n\t \tDiff:\n\t \t---
  Expected\n\t \t+++ Actual\n\t \t@@ -1,2 +1,2 @@\n\t
  \ \t-(v1alpha1.InstallPlanPhase) (len=8) "Complete"\n\t \t+(v1alpha1.InstallPlanPhase)
  (len=6) "Failed"\n\t \t \n\n/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:162"
  meandurationsec: 17.316913
  skippedtests:
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should have created the expected
prometheus objects'
counts: 1
details: []
meandurationsec: 38.088486
classname: End-to-end
name: 'Subscription updates existing install plan'
counts: 1
details: []
meandurationsec: 0.024455
classname: End-to-end
name: 'Subscriptions create required objects from Catalogs Given a Namespace
when a CatalogSource is created with a bundle that contains prometheus objects
creating a subscription using the CatalogSource should install the operator
successfully'
counts: 1
details: []
meandurationsec: 10.108268
classname: End-to-end
name: 'Catalog image update'
counts: 1
details: []
meandurationsec: 0.01919

openshift-bot · 2020-10-27T22:12:13Z

/retest