Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1891995: Add spec hash to service's label to ensure service is correct #1848

Merged
merged 2 commits into from Nov 3, 2020
Merged

Bug 1891995: Add spec hash to service's label to ensure service is correct #1848

merged 2 commits into from Nov 3, 2020

Conversation

dinhxuanvu
Copy link
Member

Calculate has from service spec and add it to service's labels.
Will use this hash info to ensure service during catalog source
reconciliation. This feature will force OLM to recreate new
service if the hash doesn't match to avoid stale service with
the same name.

Signed-off-by: Vu Dinh vdinh@redhat.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 2, 2020
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: This pull request references Bugzilla bug 1891995, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1891995: Add service spec hash to service's label to avoid stale service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu dinhxuanvu force-pushed the svc-hash branch 2 times, most recently from 7947806 to 6d6a1e6 Compare November 2, 2020 18:05
@dinhxuanvu dinhxuanvu changed the title Bug 1891995: Add service spec hash to service's label to avoid stale service Bug 1891995: Add spec hash to service's label to ensure service is correct Nov 2, 2020
exdx
exdx reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just left some small comments. I think an e2e test could also be helpful.

pkg/controller/registry/reconciler/configmap.go Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Outdated Show resolved Hide resolved
@dinhxuanvu
Add spec hash to service's label to ensure service is correct
07c9c32 
Calculate hash from service spec and add it to service's labels.
Will use this hash info to ensure service during catalog source
reconciliation. This feature will force OLM to recreate new
service if the hash doesn't match to avoid stale service with
the same name.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@exdx
Copy link
Member

exdx commented Nov 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@ecordell
Copy link
Member

ecordell commented Nov 2, 2020

/approve

looks good, but missing tests

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@dinhxuanvu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Add unit test case to grpc and configmap reconciler test
0a85c53 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@dinhxuanvu
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit e7dea52 into operator-framework:master Nov 3, 2020
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: All pull requests linked via external trackers have merged:

Bugzilla bug 1891995 has been moved to the MODIFIED state.

In response to this:

Bug 1891995: Add spec hash to service's label to ensure service is correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member Author

/cherry-pick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 3, 2020
Merged
@openshift-cherrypick-robot
Copy link

@dinhxuanvu: new pull request created: #1851

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exdx exdx exdx left review comments

@ecordell ecordell Awaiting requested review from ecordell

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@kevinrizza kevinrizza

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dinhxuanvu @openshift-ci-robot @exdx @ecordell @kevinrizza @openshift-cherrypick-robot @openshift-merge-robot