Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): add default label to issues #1873

Merged

Conversation

exdx
Copy link
Member

@exdx exdx commented Nov 19, 2020

Adds label to default issues templates and some better contact information for users.

Note: Also sets blank_issues_enabled: false which will require upstream users to use a template when filing an issue.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@njhale
Copy link
Member

njhale commented Nov 19, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, exdx, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@exdx
Copy link
Member Author

exdx commented Nov 20, 2020

commit is related to .github contents only, e2e gcp tests not required.
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

@openshift-ci-robot
Copy link
Collaborator

@exdx: Overrode contexts on behalf of exdx: ci/prow/e2e-gcp, ci/prow/e2e-upgrade

In response to this:

commit is related to .github contents only, e2e gcp tests not required.
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@njhale
Copy link
Member

njhale commented Nov 20, 2020

Changes to github issue template config shouldn't affect tests.

/override e2e-aws-console-olm
/override e2e-aws-olm

@openshift-ci-robot
Copy link
Collaborator

@njhale: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws-console-olm
  • e2e-aws-olm

Only the following contexts were expected:

  • ci/prow/e2e-aws-console-olm
  • ci/prow/e2e-aws-olm
  • ci/prow/e2e-gcp
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

Changes to github issue template config shouldn't affect tests.

/override e2e-aws-console-olm
/override e2e-aws-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Member

njhale commented Nov 20, 2020

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm

@openshift-ci-robot
Copy link
Collaborator

@njhale: Overrode contexts on behalf of njhale: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm

In response to this:

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3cb2cfd into operator-framework:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants