Add OLM support for the Upgradeable OperatorCondition and Admin overrides #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
2 times, most recently
from
934fd4c
to
9295579
Compare
ecordell
reviewed
Dec 3, 2020
ecordell
reviewed
Dec 3, 2020
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
2 times, most recently
from
c8eeb8c
to
bbe89b4
Compare
|
Don't we also want something that can prevent the resolver from looking for updates if an operator is not upgradable? |
We talked about this (Ben asked about this) and we agreed that at this point we don't want the resolver to be involved into this. This is meant to be a separate part from the resolver and it simply prevents the operator proceed to Succeeded state but not blocking the entire resolution altogether. |
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
7 times, most recently
from
dbf0611
to
02ca349
Compare
|
/retest |
1 similar comment
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
from
b393e4d
to
e3f09a9
Compare
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
from
e3f09a9
to
a7551c1
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
ecordell
reviewed
Dec 4, 2020
ecordell
reviewed
Dec 4, 2020
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
from
a7551c1
to
f9ff01a
Compare
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
2 times, most recently
from
2fab671
to
c1506cf
Compare
|
/retest |
1 similar comment
|
/retest |
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
3 times, most recently
from
cb1fe22
to
b35528a
Compare
|
/lgtm |
OLM will check for OperatorCondition CR for OperatorUpgradeable status. The pending CSV will not transition to Succeeded status until the operator is upgradeable based on the OperatorCondition. If the operator doesn't use OperatorCondition, the normal transition is expected. Cluster Admin will be able to override the OperatorUpgradeable condition. Add an e2e test for OperatorUpgradeable condition. OLM will check for replacedCSV's Upgradeable condition to ensure the new CSV is able to be upgraded. If the previous condition is False, the new CSV will stay in Pending to prevent the deployment to be installed. Signed-off-by: Vu Dinh <vdinh@redhat.com>
dinhxuanvu
force-pushed
the
create-operatorconditions-for-operator
branch
from
b35528a
to
abaf218
Compare
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/QE-approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
OLM will check for OperatorCondition CR for OperatorUpgradeable status.
The pending CSV will not transition to Succeeded status until the operator
is upgradeable based on the OperatorCondition. If the operator doesn't use
OperatorCondition, the normal transition is expected.
Signed-off-by: Vu Dinh vdinh@redhat.com
Motivation for the change:
Reviewer Checklist
/docs