Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators/catalog: support secrets in InstallPlans #189

Merged
merged 12 commits into from Dec 6, 2017
Merged

operators/catalog: support secrets in InstallPlans #189

merged 12 commits into from Dec 6, 2017

Conversation

jzelinskie
Copy link
Contributor

No description provided.

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - test it on the cluster?

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

ecordell
ecordell previously approved these changes Dec 5, 2017
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - test it on the cluster

ecordell
ecordell previously approved these changes Dec 6, 2017
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie
Copy link
Contributor Author

@ecordell your commits lgtm

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit 02fe706 into operator-framework:master Dec 6, 2017
@jzelinskie jzelinskie deleted the ip-secret branch December 6, 2017 03:43
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
operators/catalog: support secrets in InstallPlans
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
operators/catalog: support secrets in InstallPlans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants