Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1910160: Multiple operatorconditions should not update the same deployment #1900

Merged
merged 1 commit into from Dec 23, 2020
Merged

Bug 1910160: Multiple operatorconditions should not update the same deployment #1900

merged 1 commit into from Dec 23, 2020

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Dec 9, 2020

Problem: If OLM creates an OperatorConditions for an object before the
CSV is being installed it could update the existing deployment which is
not upgradeable, killing the pod.

Solution: Do not create the OperatorCondition until the CSV is being
installed.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@awgreene awgreene changed the title Create OperatorConditions for CSVs being installed WIP: Create OperatorConditions for CSVs being installed Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2020
@awgreene awgreene force-pushed the post-pending-operatorconditions branch 2 times, most recently from 35d4050 to 4d63e4b Compare December 19, 2020 23:07
@openshift-merge-robot
Copy link
Collaborator

@awgreene: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 4d63e4b link /test e2e-aws-console-olm
ci/prow/e2e-aws-olm 4d63e4b link /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awgreene
Multiple operatorconditions should not update the same deployment
0919c12 
Problem: If two OperatorConditions exist which target the same
Deployment, they will both update the environment variables with
their name continuously.

Solution: Only allow OperatorConditions to update a deployment's
environment variables if the deployment is owned by a CSV with the same
name of the OperatorCondition.
@awgreene awgreene force-pushed the post-pending-operatorconditions branch from 4d63e4b to 0919c12 Compare December 22, 2020 21:47
@awgreene awgreene changed the title WIP: Create OperatorConditions for CSVs being installed Bug 1910160: Create OperatorConditions for CSVs being installed Dec 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 22, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1910160, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1910160: Create OperatorConditions for CSVs being installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1910160, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 22, 2020
dinhxuanvu
dinhxuanvu requested changes Dec 22, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a nit comment.

pkg/controller/operators/operatorcondition_controller.go Show resolved Hide resolved
dinhxuanvu
dinhxuanvu approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1e74520 into operator-framework:master Dec 23, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: All pull requests linked via external trackers have merged:

Bugzilla bug 1910160 has been moved to the MODIFIED state.

In response to this:

Bug 1910160: Create OperatorConditions for CSVs being installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene awgreene changed the title Bug 1910160: Create OperatorConditions for CSVs being installed Bug 1910160: OperatorConditions should only update owned deployments Dec 23, 2020
@awgreene awgreene changed the title Bug 1910160: OperatorConditions should only update owned deployments Bug 1910160: Multiple operatorconditions should not update the same deployment Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@awgreene @openshift-merge-robot @openshift-ci-robot @openshift-bot @dinhxuanvu