Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs channel naming design #1905

Merged
merged 2 commits into from Dec 15, 2020
Merged

Docs channel naming design #1905

merged 2 commits into from Dec 15, 2020

Conversation

jmccormick2001
Copy link

Description of the change:
This PR holds documentation only, specifically a new document that describes Channel Naming conventions, or recommended
naming for channels.

Motivation for the change:
We would like to provide some general guidance on channel naming to better standardize
how operator authors define channels and offer some background on channel names.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmccormick2001
To complete the pull request process, please assign ecordell after the PR has been reviewed.
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmccormick2001
Copy link
Author

/retest

@jmccormick2001
Copy link
Author

/test e2e-aws-olm

1 similar comment
@jmccormick2001
Copy link
Author

/test e2e-aws-olm

@jmccormick2001
Copy link
Author

/assign @ecordell

@jmccormick2001
Copy link
Author

/test e2e-aws-olm

@openshift-merge-robot
Copy link
Collaborator

@jmccormick2001: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 6567495 link /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevinrizza kevinrizza merged commit ffb66b0 into operator-framework:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants