Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker driver for minikube installation test. #1983

Merged
merged 1 commit into from Jan 29, 2021

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Jan 29, 2021

Something changed (either in a new minikube version or the runner bump
to Ubuntu 20) and minikube isn't honoring the vm-driver=none
config. I'm guessing that it has something to do with running minikube start
with sudo but minikube config without. This test now uses the
newer docker driver in an effort to sidestep the issue completely.

Something changed (either in a new minikube version or the runner bump
to Ubuntu 20) and minikube isn't honoring the vm-driver=none
config. I'm guessing that it has something to do with running minikube
start with sudo but minikube config without. This test now uses the
newer docker driver in an effort to sidestep the issue completely.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@benluddy
Copy link
Contributor Author

This only touches Github Actions config. Overriding the pricier downstream tests.

/override e2e-aws-console-olm
/override e2e-aws-olm
/override e2e-gcp
/override e2e-upgrade

@openshift-ci-robot
Copy link
Collaborator

@benluddy: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws-console-olm
  • e2e-aws-olm
  • e2e-gcp
  • e2e-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws-console-olm
  • ci/prow/e2e-aws-olm
  • ci/prow/e2e-gcp
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

This only touches Github Actions config. Overriding the pricier downstream tests.

/override e2e-aws-console-olm
/override e2e-aws-olm
/override e2e-gcp
/override e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Copy link
Contributor Author

@benluddy: /override requires a failed status context to operate on.
The following unknown contexts were given:

* `e2e-aws-console-olm`

* `e2e-aws-olm`

* `e2e-gcp`

* `e2e-upgrade`

Only the following contexts were expected:

* `ci/prow/e2e-aws-console-olm`

* `ci/prow/e2e-aws-olm`

* `ci/prow/e2e-gcp`

* `ci/prow/e2e-upgrade`

* `ci/prow/images`

* `ci/prow/unit`

* `ci/prow/verify`

* `tide`

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

@openshift-ci-robot
Copy link
Collaborator

@benluddy: Overrode contexts on behalf of benluddy: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade

In response to this:

@benluddy: /override requires a failed status context to operate on.
The following unknown contexts were given:

* `e2e-aws-console-olm`

* `e2e-aws-olm`

* `e2e-gcp`

* `e2e-upgrade`

Only the following contexts were expected:

* `ci/prow/e2e-aws-console-olm`

* `ci/prow/e2e-aws-olm`

* `ci/prow/e2e-gcp`

* `ci/prow/e2e-upgrade`

* `ci/prow/images`

* `ci/prow/unit`

* `ci/prow/verify`

* `tide`

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@exdx
Copy link
Member

exdx commented Jan 29, 2021

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2021

@benluddy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp daa7fd2 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy benluddy merged commit 93c7978 into operator-framework:master Jan 29, 2021
@benluddy
Copy link
Contributor Author

benluddy commented Feb 3, 2021

/cherry-pick release-4.6

Downstream jobs on release-4.6 are upset about the failure of this job.

@openshift-cherrypick-robot

@benluddy: new pull request created: #1988

In response to this:

/cherry-pick release-4.6

Downstream jobs on release-4.6 are upset about the failure of this job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants