Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1929904: Infer package name property for unannotated CSVs, if possible. #2033

Merged
merged 2 commits into from Mar 12, 2021
Merged

Bug 1929904: Infer package name property for unannotated CSVs, if possible. #2033

merged 2 commits into from Mar 12, 2021

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Mar 5, 2021

Backport of #1993 to release-4.7.

benluddy and others added 2 commits March 5, 2021 17:23
@benluddy
Infer package name property for unannotated CSVs, if possible.
60cacbb 
If a CSV is missing the properties annotation, but it is referenced in
a Subscription's .status.installedCSV and is available in the same
Subscription's referenced catalog, then the CSV can be treated as
though it has a package annotation.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
@joelanford @benluddy
pkg/controller/operators/operator_controller_test.go: fix flaky test
fcb39c3 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci-robot
Copy link
Collaborator

@benluddy: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] Infer package name property for unannotated CSVs, if possible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@benluddy benluddy mentioned this pull request Mar 5, 2021
Closed
@benluddy benluddy changed the title [release-4.7] Infer package name property for unannotated CSVs, if possible. [release-4.7] Bug 1929904: Infer package name property for unannotated CSVs, if possible. Mar 5, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 5, 2021
@openshift-ci-robot
Copy link
Collaborator

@benluddy: This pull request references Bugzilla bug 1929904, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1921953 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1921953 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

In response to this:

[release-4.7] Bug 1929904: Infer package name property for unannotated CSVs, if possible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2021
@njhale
Copy link
Member

njhale commented Mar 5, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2021
@crawford crawford changed the title [release-4.7] Bug 1929904: Infer package name property for unannotated CSVs, if possible. Bug 1929904: Infer package name property for unannotated CSVs, if possible. Mar 11, 2021
@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9db1fea into operator-framework:release-4.7 Mar 12, 2021
@openshift-ci-robot
Copy link
Collaborator

@benluddy: All pull requests linked via external trackers have merged:

Bugzilla bug 1929904 has been moved to the MODIFIED state.

In response to this:

Bug 1929904: Infer package name property for unannotated CSVs, if possible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford joelanford mentioned this pull request Mar 12, 2021
Closed
@benluddy
Copy link
Contributor Author

/cherry-pick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 15, 2021
Closed
@openshift-cherrypick-robot
Copy link

@benluddy: new pull request created: #2042

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy benluddy mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@benluddy @openshift-ci-robot @njhale @openshift-bot @crawford @openshift-cherrypick-robot @openshift-merge-robot @joelanford