Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1965069: Simplify deployment status check to reduce flapping. #2176

Commits on May 26, 2021

  1. Simplify deployment status check to reduce flapping.

    The deployment status logic (originally based on kubectl's rollout
    status) can impact its ClusterServiceVersion's status (e.g. by sending
    it to Failed/ComponentUnhealthy or triggering reinstallation). If
    these ClusterServiceVersion status updates are generated when no
    changes have been made to the Deployment spec and when the Deployment
    itself has condition Available: True, then the usefulness of
    ClusterServiceVersion statuses as a signal is reduced.
    
    This patch changes the deployment status logic so that it is
    considered "done" when a) there are no replicas from earlier
    generations, and b) the Deployment has condition Available: true.
    
    Signed-off-by: Ben Luddy <bluddy@redhat.com>
    benluddy authored and openshift-cherrypick-robot committed May 26, 2021
    Copy the full SHA
    e830cc2 View commit details
    Browse the repository at this point in the history