Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1968226: Fix inconsistent dependency candidate order. #2184

Merged
merged 1 commit into from Jun 11, 2021
Merged

[release-4.6] Bug 1968226: Fix inconsistent dependency candidate order. #2184

merged 1 commit into from Jun 11, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2149

/assign benluddy

@benluddy
Fix inconsistent dependency candidate order.
39635f4 
After bundle dependency candidates are sorted, a second query is made
to the catalog cache. This query filters by CSV name alone, so it's
ambiguous when the same CSV name appears in multiple channels (or
packages). The query appears to be redundant, so it has been removed.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 7, 2021
Merged
@openshift-ci openshift-ci bot requested review from awgreene and hasbro17 June 7, 2021 00:57
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

@openshift-cherrypick-robot: Bugzilla bug 1945702 has been cloned as Bugzilla bug 1968226. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1968226: Fix inconsistent dependency candidate order.

In response to this:

[release-4.6] [release-4.7] Bug 1945702: Fix inconsistent dependency candidate order.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.6] [release-4.7] Bug 1945702: Fix inconsistent dependency candidate order. [release-4.6] [release-4.7] Bug 1968226: Fix inconsistent dependency candidate order. Jun 7, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1968226, which is invalid:

  • expected dependent Bugzilla bug 1945702 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] [release-4.7] Bug 1968226: Fix inconsistent dependency candidate order.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@benluddy benluddy changed the title [release-4.6] [release-4.7] Bug 1968226: Fix inconsistent dependency candidate order. [release-4.6] Bug 1968226: Fix inconsistent dependency candidate order. Jun 7, 2021
@benluddy
Copy link
Contributor

benluddy commented Jun 7, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@openshift-bot: This pull request references Bugzilla bug 1968226, which is invalid:

  • expected dependent Bugzilla bug 1945702 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@timflannagan: This pull request references Bugzilla bug 1968226, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1945702 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1945702 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@timflannagan: This pull request references Bugzilla bug 1968226, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1945702 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1945702 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 10, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cf3f9b2 into operator-framework:release-4.6 Jun 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1968226 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1968226: Fix inconsistent dependency candidate order.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene Awaiting requested review from awgreene

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@joelanford joelanford

@benluddy benluddy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @joelanford @benluddy @openshift-bot @timflannagan @ecordell @openshift-merge-robot