Update default catalog namespace #2371
Conversation
default global catalog namespace shouldn't be vendor specific
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
| @@ -28,7 +28,7 @@ import ( | |||
| const ( | |||
| catalogNamespaceEnvVarName = "GLOBAL_CATALOG_NAMESPACE" | |||
| defaultWakeupInterval = 15 * time.Minute | |||
| defaultCatalogNamespace = "openshift-operator-lifecycle-manager" | |||
| defaultCatalogNamespace = "olm" | |||
There was a problem hiding this comment.
maybe default is even more agnostic?
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/unit |
|
@njhale: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
holding so the bot doesn't go crazy - hopefully have a fix for that problematic unit test. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Closing/re-opening as the re-testing the unit test was checking out the wrong master branch commit. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
default global catalog namespace shouldn't be vendor specific