test/e2e: Wrap flake-prone garbage collection tests in eventually assertions #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
force-pushed
the
fix-gc-e2e-flakes
branch
2 times, most recently
from
9163ac6
to
cf49231
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
tylerslaton
reviewed
Oct 6, 2021
timflannagan
force-pushed
the
fix-gc-e2e-flakes
branch
from
9a990e1
to
01c43f0
Compare
…ertions Update the test/e2e/gc_e2e_test.go and wrap any error-prone test blocks in eventually assertions to reduce the number of flakes that occur when attempting to create/update/delete/etc. Kubernetes resources during individual CI runs on these garbage collection specs. Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
fix-gc-e2e-flakes
branch
from
01c43f0
to
bf3395e
Compare
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the test/e2e/gc_e2e_test.go and wrap any error-prone test blocks
in eventually assertions to reduce the number of flakes that occur when
attempting to create/update/delete/etc. Kubernetes resources during
individual CI runs on these garbage collection specs.
Signed-off-by: timflannagan timflannagan@gmail.com
Reviewer Checklist
/doc