UT - add possible error message patterns for resolve failure #2565

akihikokuroda · 2022-01-11T17:24:18Z

Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com

Description of the change:
The test fails when the error message doesn't have the expected string. There are different error messages generated by the test and they are also valid error messages. This change accept multiple strings as the expected string in the error messages.
Here are valid error messages that I captured so far:

subscription packageA-alpha requires test-catalog/test-namespace/alpha/packageA.v1, subscription packageA-alpha exists, package: packageC is not white listed, bundle packageA.v1 requires an operator providing an API with group: g, version: v, kind: k, package: packageB is not white listed
package: packageC is not white listed, package: packageB is not white listed, subscription packageA-alpha requires test-catalog/test-namespace/alpha/packageA.v1, subscription packageA-alpha exists, bundle packageA.v1 requires an operator providing an API with group: g, version: v, kind: k
subscription packageA-alpha requires test-catalog/test-namespace/alpha/packageA.v1, subscription packageA-alpha exists, package: packageA is not white listed
package: packageA is not white listed, subscription packageA-alpha requires test-catalog/test-namespace/alpha/packageA.v1, subscription packageA-alpha exists

Motivation for the change:
Closes #2564
Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /doc
Commit messages sensible and descriptive

openshift-ci · 2022-01-11T17:24:28Z

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akihikokuroda · 2022-01-11T19:26:45Z

The Unit test failure should be addressed in #2547

awgreene

Great work @akihikokuroda , I have a suggestion.

pkg/controller/registry/resolver/resolver_test.go

awgreene · 2022-01-14T19:22:45Z

/ok-to-test

awgreene · 2022-01-14T20:08:59Z

@perdasilva and I spoke about this offline, and we think it might be best to leave #2564 open to track the non-deterministic behavior of OLM in this space. When OLM is deterministic, it should reintroduce a test that is similar to the existing format.

awgreene · 2022-01-14T20:13:22Z

/approve

openshift-ci · 2022-01-14T20:13:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>

perdasilva · 2022-01-16T20:55:41Z

/lgtm

openshift-bot · 2022-01-16T21:51:03Z

/retest-required