.github: Avoid disabling the go mod pkg cache for the golangci-lint action #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
force-pushed
the
remove-skip-pkg-cache-golangci-lint
branch
3 times, most recently
from
d1c8b2d
to
dd365ca
Compare
Update the sanity workflow and avoid setting the 'skip-pkg-cache' option to true so the golangci-lint action can start caching and restoring the ~/go/pkg directory during CI runs. Signed-off-by: timflannagan <timflannagan@gmail.com>
As advertised in the action's official documentation, it's easier to separate this action into it's own job so it can run in parallel with other jobs defined within an individual workflow. When removing this flag in the previous commit, the action was silently failing as it couldn't access the go module package cache due to what appeared to be permissions-related failures. Moving the golangci-lint action to it's own job fixed those silent failures. Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
force-pushed
the
remove-skip-pkg-cache-golangci-lint
branch
from
dd365ca
to
117a4e0
Compare
|
Nice! /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the sanity workflow and avoid setting the 'skip-pkg-cache' option
to true so the golangci-lint action can start caching and restoring the
~/go/pkg directory during CI runs.
Signed-off-by: timflannagan timflannagan@gmail.com
Motivation for the change:
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky