Remove import of operators.coreos.com lister package from resolver. #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
benluddy
force-pushed
the
remove-listers-import-from-resolver
branch
from
03de87f
to
7acb454
Compare
openshift-ci
bot
removed
the
needs-rebase
benluddy
force-pushed
the
remove-listers-import-from-resolver
branch
from
7acb454
to
ae72768
Compare
|
/assign @tylerslaton |
A test double was missed when cache.SourcePriorityProvider was introduced. These resolver-to-nonresolver package imports will make it difficult for the resolution component to stand on its own as a library module. Signed-off-by: Ben Luddy <bluddy@redhat.com>
benluddy
force-pushed
the
remove-listers-import-from-resolver
branch
from
ae72768
to
6e96162
Compare
| namespace: namespace, | ||
| } | ||
| func (spp stubSourcePriorityProvider) Priority(k cache.SourceKey) int { | ||
| return spp[k] |
There was a problem hiding this comment.
Do we need to null check this $somewhere to avoid a panic?
There was a problem hiding this comment.
Oh, disregard - I think this is fine as it should just return 0 when indexing on a key that doesn't exist.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test double was missed when cache.SourcePriorityProvider was
introduced. These resolver-to-nonresolver package imports will make it
difficult for the resolution component to stand on its own as a
library module.