Mitigate flaky install plan e2e test #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold don't merge until flake analysis is complete |
openshift-ci
bot
added
the
do-not-merge/hold
|
Looks like it's no longer flaky. At least on local: $ for i in (seq 1 50); make e2e-local TEST="can reconcile InstallPlan status" ; end | tee flake_test_run.txt
$ cat flake_test_run.txt | grep -i "1 Passed" | wc -l
50 |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
force-pushed
the
flake_install_plan
branch
from
138e6b3
to
264d70a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: perdasilva perdasilva@redhat.com
Description of the change:
This PR adds a mitigation around a flaky installplan e2e test. I ran out of time to properly fix the issue and didn't want to lose the work on the RCA. So I've created an issue that describes the problem and tracks the problem: #2667
Motivation for the change:
Fixing a flaky e2e test
Closes #2645
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky