Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Kube client #2712

Merged

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
This PR introduces the e2e kubernetes client. It tags and keeps track of resources created/updated with it and has a method to delete all resources.

Motivation for the change:
This client should eventually be used with the e2e tests to help with resource leaks

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky
  • Tests that remove the [FLAKE] tag are no longer flaky

@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@perdasilva perdasilva changed the title Resource manager E2E Kube client Mar 25, 2022
@perdasilva perdasilva force-pushed the resource_manager branch 5 times, most recently from 5fac844 to a763c5d Compare April 1, 2022 07:44
@perdasilva perdasilva force-pushed the resource_manager branch 4 times, most recently from cb15c8d to f2184b1 Compare April 5, 2022 16:56
Signed-off-by: perdasilva <perdasilva@redhat.com>
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit b75c76f into operator-framework:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants