fix(install/deployment): use ownerreferences when checking for SAs #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents a bug during CSV upgrades where serviceaccounts are orphaned. Installing the new CSV would see the serviceaccount existed and not update it, but it would ownerrefs to the old CSV and be gargabe collected eventually.
ecordell
force-pushed
the
orphaned-resources-csv-upgrade
branch
2 times, most recently
from
2feed0c
to
6d183ae
Compare
the responses we get from the listwatcher are missing this information for some reason, hardcoding until we fix the underlying issue
ecordell
force-pushed
the
orphaned-resources-csv-upgrade
branch
from
f05dd91
to
ffa5eaf
Compare
alecmerdler
approved these changes
Feb 9, 2018
| } | ||
|
|
||
| func AddNonBlockingOwner(object metav1.Object, owner Owner) { | ||
| // TODO: Remove as soon as possible |
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
…urces-csv-upgrade fix(install/deployment): use ownerreferences when checking for SAs
ecordell
added a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…urces-csv-upgrade fix(install/deployment): use ownerreferences when checking for SAs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents a bug during CSV upgrades where serviceaccounts are
orphaned. Installing the new CSV would see the serviceaccount existed
and not update it, but it would ownerrefs to the old CSV and be gargabe
collected eventually.