resolver: Add support for excluding global catalogs from resolution #2788
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
exdx
force-pushed
the
exclude-global-ns
branch
2 times, most recently
from
c995b5e
to
abfdd0f
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
force-pushed
the
exclude-global-ns
branch
from
abfdd0f
to
d90a5ad
Compare
|
I squashed everything down to one commit (made Per the co-author on it as well). The e2e test needs #2801 to go in first (that was originally part of this branch, but was broken out separately since its unrelated), then this can be rebased again, and it should be good after that. |
There was a problem hiding this comment.
Do you want to make the error text in cache.go unspecific to catalogs? Maybe something like "failed to populate resolver cache from source %v: %w"?
That sounds good -- should make the error message more clear |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The resolver is currently configured to always consider resolving from global catalogs. In some cases, this may not be desirable, and the user would like to explicitly ignore global catalogs for the purposes of resolution. This change enables per-namespace exclusion from global catalog sources via an annotation on existing registry source provider. A queueinformer for OperatorGroups is added since they are now an input to resolution via the global catalog exclusion annotation. Namespace resolution will be triggered on changes to an OperatorGroup, in case the value provided on that annotation by the user changes. Updated the error message returned by the cache in case a source has an error to be more clear. Signed-off-by: Daniel Sover <dsover@redhat.com> Co-authored-by: perdasilva <perdasilva@redhat.com>
|
/lgtm |
The resolver is currently configured to always consider resolving
from global catalogs. In some cases, this may not be
desirable, and the user would like to explicitly ignore global catalogs
for the purposes of resolution. This change enables per-namespace
exclusion from global catalog sources via an annotation on the
operatorgroup.
The operatorgroup annotation key is
olm.operatorframework.io/exclude-global-namespace-resolutionand setting the value to
"true"will cause resolution to exclude global catalogs in that namespace.Signed-off-by: Daniel Sover dsover@redhat.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky