flaky-e2e-tests fix #3070
Merged
flaky-e2e-tests fix #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtfranz
commented
Oct 19, 2023
dinhxuanvu
requested changes
Oct 19, 2023
dtfranz
force-pushed
the
flake-e2e-fix
branch
from
63a0c15
to
f0dc9c4
Compare
openshift-ci
bot
added
lgtm
E2E tests were updated recently to use a generated namespace with an OperatorGroup created from the beginning of each test. However some of the tests were not updated to reflect this and were still creating and deleting resources in an additional namespace, or began to fail because the test environment required that no OperatorGroups exist from the beginning of the test. This commit addresses two tests that have been failing at a rate of 100% due to the issues stated above. Signed-off-by: Daniel Franz <dfranz@redhat.com>
|
/lgtm |
tmshort
approved these changes
Oct 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, dtfranz, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dtfranz
force-pushed
the
flake-e2e-fix
branch
from
f0dc9c4
to
0f58549
Compare
|
/lgtm |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:master
with commit Oct 19, 2023
91b5762
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing flake tests so they don't fail 100% of the time.
E2E tests were updated recently to use a generated namespace with an OperatorGroup created from the beginning of each test. However some of the tests were not updated to reflect this and were still creating and deleting resources in an additional namespace, or began to fail because the test environment required that no OperatorGroups exist from the beginning of the test.
This commit addresses two tests that have been failing at a rate of 100% due to the issues stated above.