Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] cleanup/tools #3227

Closed
wants to merge 17 commits into from
Closed

[WIP] cleanup/tools #3227

wants to merge 17 commits into from

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@openshift-ci openshift-ci bot requested review from anik120 and oceanc80 May 7, 2024 08:29
Per Goncalves da Silva added 9 commits May 7, 2024 11:38
add bingo to manage tools, e.g. kind
54cffa5 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
add helm to bingo
6961434 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
set E2E_NODES=1 for e2e tests
3a022d4 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
deploy e2e test environment in make
1f9cff7 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove helm and kind provisioning from e2e package
c87277c 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix .bingo mod files
2b9d299 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
swap ginkgo --progress (deprected) for --show-node-events
38a73d1 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix kind variables and use the appropriate node image
a152423 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
add seteup_envtest
62b1b06 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the cleanup/tools branch 4 times, most recently from 9a0f1ea to d7e7041 Compare May 7, 2024 10:24
remove go-bindata
709ffd9 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Per Goncalves da Silva added 5 commits May 7, 2024 14:13
move yq to bingo
2c60f0c 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove ginkgo from tools.go
3f1d487 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove gnostic from tools.go
a204a52 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove helm from tools.go
2a5fcb6
remove forgotten files
0a343b4 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Per Goncalves da Silva added 2 commits May 8, 2024 14:04
revert changes to deploy/upstream
e8fac55 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update vendor
8612867 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@perdasilva perdasilva changed the title [WIP] Cleanup/tools [WIP] cleanup/tools May 10, 2024
@perdasilva perdasilva closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@perdasilva @openshift-merge-robot