Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] clean-up: build make targets #3228

Closed
wants to merge 27 commits into from
Closed

[WIP] clean-up: build make targets #3228

wants to merge 27 commits into from

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@perdasilva perdasilva changed the title clean-up: [WIP] clean-up: build make targets May 7, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@openshift-ci openshift-ci bot requested review from dinhxuanvu and dtfranz May 7, 2024 14:43
Per Goncalves da Silva added 26 commits May 8, 2024 16:34
add bingo to manage tools, e.g. kind
fdbc812 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
add helm to bingo
b4f5b92 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
set E2E_NODES=1 for e2e tests
e87f5b7 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
deploy e2e test environment in make
212153b 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove helm and kind provisioning from e2e package
27f7e79 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix .bingo mod files
928881c 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
swap ginkgo --progress (deprected) for --show-node-events
bdf54bb 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix kind variables and use the appropriate node image
ced288b 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
add seteup_envtest
d9e3309 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove go-bindata
96e03ff 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
move yq to bingo
e307886 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove ginkgo from tools.go
df99889 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove gnostic from tools.go
7001b0b 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove helm from tools.go
f934a45
remove forgotten files
e655ea3 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
refactory make build targets
bf7fb98 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
remove cruft
8c5352b 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update build workflow
e61253d 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update e2e workflows
f95d9c4 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
update makefile
3d6158f 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix unit tests
c1af8fa 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix quickstart
bf5f92e 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
fix e2e
2269147 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
revert changes to install.sh
8e75ed4 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
makefile cosmetic fixes
638ed00 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
revert deploy/upstream
50942a2 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
makefile cosmetic fixes
891def2 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@perdasilva perdasilva closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@dtfranz dtfranz Awaiting requested review from dtfranz

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@perdasilva @openshift-merge-robot