Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 parameterizes the e2e target and pins opm images #3275

Merged
merged 3 commits into from
May 24, 2024

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 23, 2024

Description of the change:
The previous refactored parametrization of the e2e target was too restrictive. This PR re-introduces parameters to configure the e2e test command.

It has also come to our attention that opm:latest images are being used in e2e tests. This PR also pins the opm images to the relevant version of operator-registry

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@perdasilva perdasilva changed the title 🌱 fixes [wip] 🌱 fixes May 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
@openshift-ci openshift-ci bot requested review from dtfranz and grokspawn May 23, 2024 16:08
@perdasilva perdasilva force-pushed the fixup/e2e-params branch 3 times, most recently from 9616e7e to c0803bf Compare May 23, 2024 18:04
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the fixup/e2e-params branch 3 times, most recently from 22dc6b9 to 07cf78e Compare May 23, 2024 18:27
@perdasilva perdasilva changed the title [wip] 🌱 fixes 🌱 parameterizes the e2e target and pins opm images May 23, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
@perdasilva perdasilva enabled auto-merge May 23, 2024 20:01
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Per Goncalves da Silva added 2 commits May 23, 2024 22:09
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me from a code change perspective, but I'm not to familiar with this code base and how effective this change is. If we trust our e2e tests then LGTM :)

@tmshort
Copy link
Contributor

tmshort commented May 23, 2024

unit tests are now failing :(
And the only change was the export‽‽

@perdasilva
Copy link
Collaborator Author

unit tests are now failing :( And the only change was the export‽‽

Flake (already investing XD - I'll get this repo stable if it kills me!)

@perdasilva perdasilva added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@perdasilva perdasilva added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@perdasilva perdasilva added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@perdasilva perdasilva added this pull request to the merge queue May 24, 2024
Merged via the queue into operator-framework:master with commit 1f5e0dc May 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants