Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ownership conflicts for CRDs #375

Merged
merged 1 commit into from Jul 5, 2018

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Jul 3, 2018

Prevent a CSV from installing if there is another CSV in the namespace that owns the same CRD, but isn't being replaced.

https://jira.coreos.com/browse/ALM-608

@ecordell ecordell added kind/bug Categorizes issue or PR as related to a bug. internal/tracked This issue is tracked in the internal JIRA labels Jul 3, 2018
@ecordell ecordell requested a review from alecmerdler July 3, 2018 15:26
alecmerdler
alecmerdler previously approved these changes Jul 3, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

CSV in the namespace that owns the same CRD, but isn't being replaced.
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit 489958d into operator-framework:master Jul 5, 2018
@ecordell ecordell deleted the check-doubleowner branch July 6, 2018 14:22
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
…wner

Prevent ownership conflicts for CRDs
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…wner

Prevent ownership conflicts for CRDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/tracked This issue is tracked in the internal JIRA kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants