Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated prometheus csv according to the integration into openshift #425

Merged
merged 1 commit into from Aug 21, 2018
Merged

updated prometheus csv according to the integration into openshift #425

merged 1 commit into from Aug 21, 2018

Conversation

sichvoge
Copy link
Collaborator

As discussed, I updated the following fields:

  • displayName -> Prometheus Operator
  • description -> included Prometheus Operator info
  • Maintainers and Provider -> Red Hat with openshift-operators@redhat.com
  • Maturity -> beta

Changed:

  • Alert Manager -> Alertmanager

cc/ @brancz

@ecordell ecordell added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 17, 2018
@brancz
Copy link

brancz commented Aug 20, 2018

lgtm


**High availability**


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are getting jumbled up:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MH. This is how it is displayed for me on OLM:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok maybe I copy/pasted wrong

@ecordell ecordell closed this Aug 20, 2018
@ecordell ecordell reopened this Aug 20, 2018
@ecordell ecordell closed this Aug 20, 2018
@ecordell ecordell reopened this Aug 20, 2018
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit 2475276 into operator-framework:master Aug 21, 2018
@sichvoge sichvoge deleted the update_prometheus_csv branch August 22, 2018 11:38
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
…heus_csv

updated prometheus csv according to the integration into openshift
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…heus_csv

updated prometheus csv according to the integration into openshift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants