Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go Modules #561

Merged
merged 1 commit into from Nov 8, 2018
Merged

Conversation

alecmerdler
Copy link
Member

Description

Before:

$ make build
go: verifying k8s.io/client-go@v8.0.0+incompatible: checksum mismatch
        downloaded: h1:tTI4hRmb1DRMl4fG6Vclfdi6nTM82oIrTT7HfitmxC4=
        go.sum:     h1:2pUaSg2x6iEHr8cia6zmWhoCXG1EDG9TCx9s//Aq7HY=

After:

$ make build
CGO_ENABLED=0 go build -mod=vendor -ldflags "-w -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.GitCommit=`git rev-parse --short HEAD` -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.OLMVersion=`cat OLM_VERSION`" -o bin/catalog github.com/operator-framework/operator-lifecycle-manager/cmd/catalog;
CGO_ENABLED=0 go build -mod=vendor -ldflags "-w -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.GitCommit=`git rev-parse --short HEAD` -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.OLMVersion=`cat OLM_VERSION`" -o bin/olm github.com/operator-framework/operator-lifecycle-manager/cmd/olm;
CGO_ENABLED=0 go build -mod=vendor -ldflags "-w -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.GitCommit=`git rev-parse --short HEAD` -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.OLMVersion=`cat OLM_VERSION`" -o bin/package-server github.com/operator-framework/operator-lifecycle-manager/cmd/package-server;
CGO_ENABLED=0 go build -mod=vendor -ldflags "-w -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.GitCommit=`git rev-parse --short HEAD` -X github.com/operator-framework/operator-lifecycle-manager/pkg/version.OLMVersion=`cat OLM_VERSION`" -o bin/validator github.com/operator-framework/operator-lifecycle-manager/cmd/validator;

Addresses client-go authors mutating a release tag.

@njhale
Copy link
Member

njhale commented Nov 8, 2018

/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2018
@alecmerdler alecmerdler merged commit 668c264 into operator-framework:master Nov 8, 2018
@alecmerdler alecmerdler deleted the fix-gomodules branch November 8, 2018 21:03
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants