Service Catalog CSV: update resource limitations #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Is there any way that we could just adjust those to values that are sensible for service catalog? |
jboyd01
force-pushed
the
remove-resource-limits
branch
from
8bb2b44
to
2e56fd4
Compare
openshift-ci-robot
added
size/XS
|
Let's go with bumping up the limits for the embedded etcd container. Note that this container will be removed (hopefully soon) and we'll be using openshift's etcd instance. Thanks for the discussion on this @ecordell |
|
/retest |
jboyd01
changed the title
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ecordell
added a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…e-limits Service Catalog CSV: update resource limitations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are getting errors with etcd container unable to allocate memory. I think these were copied from a default template - we've never had resource limitations on our containers in either OpenShift Service Catalog or upstream.