Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unit): fix test flakes in TestTransitionCSV #814

Closed
wants to merge 1 commit into from
Closed

fix(unit): fix test flakes in TestTransitionCSV #814

wants to merge 1 commit into from

Conversation

jpeeler
Copy link
Contributor

@jpeeler jpeeler commented Apr 13, 2019

I can't get the unit tests in #809 to pass. This might not be the right fix, but can hopefully at least serve as inspiration. The other call to op.syncClusterServiceVersion is in a loop presumably to provide determinism, so that is copied here.

@jpeeler
fix(unit): fix test flakes in TestTransitionCSV
dc893a5 
Sync op.syncClusterServiceVersion enough times to be deterministic.
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2019
@jpeeler
Copy link
Contributor Author

jpeeler commented Apr 15, 2019

/retest
Now that all the CI issues have been cleared up, see if this passes.

@openshift-ci-robot
Copy link
Collaborator

@jpeeler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws dc893a5 link /test e2e-aws
ci/prow/e2e-aws-console-olm dc893a5 link /test e2e-aws-console-olm
ci/prow/e2e-aws-upgrade dc893a5 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jpeeler jpeeler mentioned this pull request May 1, 2019
Merged
@jpeeler jpeeler closed this May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@njhale njhale Awaiting requested review from njhale

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpeeler @openshift-ci-robot