Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reporting of operator health #100

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Add reporting of operator health #100

merged 2 commits into from
Feb 8, 2019

Conversation

aravindhp
Copy link
Member

@aravindhp aravindhp commented Jan 31, 2019 •
edited

  • Add the ClusterOperator CR to the manifests
  • Add support for reporting the health of the operator through the ClusterOperator CR
  • Update dependencies

This addresses Jira issue MKTPLC-222

@aravindhp
[vendor] Update dependencies
38b53a7 
Update after adding github.com/openshift/api,
github.com/openshift/client-go/ and github.com/openshift/library-go/
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 31, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2019
@aravindhp
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2019
@aravindhp
Copy link
Member Author

/cc @awgreene @SamiSousa @galletti94 @anik120 @jeremylinlin

@openshift-ci-robot
Copy link
Contributor

@aravindhp: GitHub didn't allow me to request PR reviews from the following users: anik120, jeremylinlin.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @awgreene @SamiSousa @galletti94 @anik120 @jeremylinlin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza
kevinrizza requested changes Jan 31, 2019
View reviewed changes
pkg/status/status.go Outdated Show resolved Hide resolved
pkg/status/status.go Show resolved Hide resolved
pkg/status/status.go Outdated Show resolved Hide resolved
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@tkashem
Copy link
Collaborator

tkashem commented Feb 5, 2019

/lgtm

@aravindhp
Copy link
Member Author

/approve

@aravindhp
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2019
@aravindhp
Copy link
Member Author

/retest

@aravindhp
Copy link
Member Author

/test images

@aravindhp
Copy link
Member Author

/test e2e-aws-operator

@aravindhp
Copy link
Member Author

/test e2e-aws

aravindhp
aravindhp commented Feb 5, 2019
View reviewed changes
pkg/status/status.go Outdated
// this API.
_, err := client.ClusterOperators().Get(clusterOperatorName, v1.GetOptions{})
coAPINotPresent := false
if meta.IsNoMatchError(err) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrizza @tkashem I discovered that the error returned when ClusterOperator CRD is not present is a generic not found error. This won't help us on vanilla kube. So instead I am going to push a change where I look for the ClusterOperator CRD itself. The downside is that I need to add the CRD scheme to the manager. Let me know what you think after I push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrizza @tkashem I have pushed that change. Please take a look.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@kevinrizza
Copy link
Member

@aravindhp Are we saying that we always need to install the ClusterOperator even on Openshift install? I thought it was just needed for vanilla kube? Are other openshift components following this pattern?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@tkashem
Copy link
Collaborator

tkashem commented Feb 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@kevinrizza
Copy link
Member

/lgtm

@aravindhp
Copy link
Member Author

/approve cancel

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@aravindhp
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@aravindhp
Copy link
Member Author

/retest

@aravindhp
Copy link
Member Author

/test e2e-aws

@aravindhp aravindhp force-pushed the cluster-operator branch 2 times, most recently from ffe1ded to 6bec0f3 Compare February 8, 2019 16:39
@aravindhp
Copy link
Member Author

/test e2e-aws

@aravindhp
Copy link
Member Author

aravindhp commented Feb 8, 2019 •
edited

@kevinrizza @tkashem I figured out that reason the e2e was failing was that the cluster role was not updated to read CRDs. I have fixed that issue and updated some logs. Please review.

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@aravindhp
Copy link
Member Author

/test e2e-aws

1 similar comment
@aravindhp
Copy link
Member Author

/test e2e-aws

@aravindhp
[status] Add reporting of operator health
2904065 
- Add the ClusterOperator CR to the manifests
- Update the cluster roles
- Add support for reporting the health of the operator through the
ClusterOperator CR

This addresses https://jira.coreos.com/browse/MKTPLC-222
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@tkashem
Copy link
Collaborator

tkashem commented Feb 8, 2019

/lgtm

@aravindhp
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit d06f7b3 into operator-framework:master Feb 8, 2019
@aravindhp aravindhp deleted the cluster-operator branch February 8, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza kevinrizza requested changes

@tkashem tkashem tkashem requested changes

@awgreene awgreene Awaiting requested review from awgreene

@SamiSousa SamiSousa Awaiting requested review from SamiSousa

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@kevinrizza kevinrizza

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aravindhp @openshift-ci-robot @kevinrizza @tkashem @openshift-bot @openshift-merge-robot