[opsrc] Fix OperatorSource reconciliation error #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/S
tkashem
force-pushed
the
csc-update
branch
2 times, most recently
from
46e2b52
to
33241f9
Compare
tkashem
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@kevinrizza @aravindhp take a look when you have time. |
aravindhp
requested changes
Feb 5, 2019
| @@ -95,6 +95,8 @@ func (r *configuringReconciler) Reconcile(ctx context.Context, in *v1alpha1.Oper | |||
| } | |||
|
|
|||
| cscExisting.EnsureGVK() | |||
| cscExisting.RemoveOwner(in.GetUID()) | |||
There was a problem hiding this comment.
Please add a comment mentioning why you are removing the owner. Looks good to me otherwise.
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
/approve cancel |
OperatorSource reconciler fails in 'Configuring' phase if the following conditions are true: - The CatalogSourceConfig object already exists. - It is already owned by the OperatorSource object. The reconciler appends the OperatorSource object to the OwnerReference list of the CatalogSourceConfig without checking whether it is already owned by the same OperatorSource. This causes the Update API to throw an error. Solution: Remove the given OperatorSource object from the OwnerReference list to ensure it is not specified more than once https://bugzilla.redhat.com/show_bug.cgi?id=1672701
|
/approve |
|
@aravindhp @kevinrizza updated the commit with bugzilla link, can I have |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
|
/test e2e-aws-operator |
|
/retest e2e-aws |
|
/test e2e-aws |
Closed
|
/test e2e-aws |
2 similar comments
|
/test e2e-aws |
|
/test e2e-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperatorSource reconciler fails in 'Configuring' phase if the
following conditions are true:
The reconciler appends the OperatorSource object to the
OwnerReference list of the CatalogSourceConfig without checking
whether it is already owned by the same OperatorSource. This causes
the Update API to throw an error.
Solution: Remove the given OperatorSource object from the
OwnerReference list to ensure it is not specified more than once.
Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1672701.