Generate typed clientset for marketplace type(s) #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate typed clientset for marketplace type(s) so that other components can access marketplace APIs. - We will use the typed client to query OperatorSource object(s) from operator-registry pod. https://jira.coreos.com/browse/MKTPLC-108 https://jira.coreos.com/browse/MKTPLC-244 TODO: - Add a make goal `make gen-clientset` that will generate the clientset using client-gen.
openshift-ci-robot
added
the
size/XL
tkashem
commented
Feb 12, 2019
| @@ -13,15 +13,8 @@ const ( | |||
| CSCFinalizer = "finalizer.catalogsourceconfigs.marketplace.redhat.com" | |||
| ) | |||
|
|
|||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
There was a problem hiding this comment.
I had to move this for client-gen to work. I ran operator-sdk generate k8s after this and it did not throw any error or produce any changes to the typeset.
|
/test e2e-aws-operator |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components can access marketplace APIs.
object(s) from operator-registry pod.
https://jira.coreos.com/browse/MKTPLC-108
https://jira.coreos.com/browse/MKTPLC-244
TODO:
make gen-clientsetthat will generate theclientset using client-gen.