Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csc] Update CSC version from v1 to v2 #203

Merged
merged 2 commits into from Jun 16, 2019
Merged

[csc] Update CSC version from v1 to v2 #203

merged 2 commits into from Jun 16, 2019

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Jun 6, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 6, 2019
@awgreene
Copy link
Member Author

awgreene commented Jun 6, 2019

Please take a look @aravindhp @kevinrizza @galletti94

gallettilance
gallettilance approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

aravindhp
aravindhp requested changes Jun 6, 2019
View reviewed changes
Copy link
Member

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @awgreene. Small nit: Please make the second commit message to [csc] Increment version.

pkg/apis/operators/shared/phase_types.go
@@ -0,0 +1,60 @@
package shared
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming you did a git mv and git decided the file was new. Was that the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It decided to create / delete the phase_type after adding the generated deepcopy functions.

@aravindhp
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2019
@aravindhp
Copy link
Member

This should go in after #198

@awgreene awgreene mentioned this pull request Jun 6, 2019
Merged
@kevinrizza
Copy link
Member

@awgreene @aravindhp Hey so I think I am slightly out of the loop here, but what is the plan here? Are we just planning on supporting both versions in a cluster? Would it not be better to just migrate any existing objects from V1 to V2 and then not support older versions?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 12, 2019
@awgreene
[refactor] Rename marketplace api imports to v1
9ca425c 
Rename Marketplace api imports from marketplace to v1 to improve
clarity.
@awgreene
[csc] Increment version
4e74db1 
This change updates the version of the CSC CRD to prepare for the
pending changes to the CatalogSourceConfig spec. This change includes:
* Creating a new api package called v2 and importing it when
  appropriate.
* Moved code that is shared between different api versions to its own
  package.
* Updated the CSC CRD.
* Adding boilerplate code to generate copyright header.
@awgreene
Copy link
Member Author

awgreene commented Jun 14, 2019 •
edited

198 has closed, please review @aravindhp @kevinrizza

@kevinrizza
Copy link
Member

/approve

gallettilance
gallettilance approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @awgreene !

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@aravindhp
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2019
@aravindhp
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, awgreene, galletti94, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aravindhp,kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene
Copy link
Member Author

/test e2e-aws-console-olm

@awgreene
Copy link
Member Author

/test e2e-aws

3 similar comments
@awgreene
Copy link
Member Author

/test e2e-aws

@awgreene
Copy link
Member Author

/test e2e-aws

@awgreene
Copy link
Member Author

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 3acfe3c into operator-framework:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@gallettilance gallettilance gallettilance approved these changes

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@aravindhp aravindhp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@awgreene @aravindhp @kevinrizza @openshift-ci-robot @gallettilance @openshift-merge-robot