Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1771277: Implement Structural Schema #270

Merged
merged 1 commit into from Dec 5, 2019
Merged

Bug 1771277: Implement Structural Schema #270

merged 1 commit into from Dec 5, 2019

Conversation

awgreene
Copy link
Member

oc explain (and kubectl explain) both broken on Kubernetes version 1.16
due to the release of CRD v1. V1 CRDs require a structural schema for oc
explain to work. This commit introduces the required changes to
implement a structural schema.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 15, 2019
@awgreene awgreene force-pushed the fix-oc-explain branch 2 times, most recently from a0059b0 to e695921 Compare November 15, 2019 19:31
@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/retest

2 similar comments
@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/retest

@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@awgreene
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@ecordell
Copy link
Member

Does this bump our minimum version requirements to 1.16?

@awgreene
Copy link
Member Author

Does this bump our minimum version requirements to 1.16?

It does not @ecordell - is there a reason you thought it might?

@awgreene
Copy link
Member Author

Does this bump our minimum version requirements to 1.16?

It does not @ecordell - is there a reason you thought it might?

@ecordell this does break k explain csc/opsrc on earlier versions (1.14 for example), but the CRDs are still deployed and usable.

@awgreene awgreene changed the title Implement Structural Schema Bug 1771277: Implement Structural Schema Nov 19, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 19, 2019
@openshift-ci-robot
Copy link
Contributor

@awgreene: This pull request references Bugzilla bug 1771277, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1771277: Implement Structural Schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevinrizza
Copy link
Member

Does this bump our minimum version requirements to 1.16?

It does not @ecordell - is there a reason you thought it might?

@ecordell this does break k explain csc/opsrc on earlier versions (1.14 for example), but the CRDs are still deployed and usable.

@ecordell @awgreene

Since we don't have a mechanism for versioning marketplace outside the scope of OpenShift version right now, it's the only way we have to deal with this. IMO I think this is okay if we are trying to move away from this project in all cases other than existing openshift versions.

@awgreene
Copy link
Member Author

/hold cancel

Properly linked to the Bugzilla.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2019
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@awgreene
Copy link
Member Author

awgreene commented Dec 4, 2019

/retest

2 similar comments
@awgreene
Copy link
Member Author

awgreene commented Dec 4, 2019

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 4, 2019

/retest

@awgreene
Copy link
Member Author

awgreene commented Dec 4, 2019

/retest

fail [github.com/openshift/origin/test/extended/marketplace/marketplace_utils.go:18]: Unexpected error:
<*util.ExitError | 0xc0031207e0>: {
Cmd: "oc --config=/tmp/admin.kubeconfig create -f /tmp/e2e-test-marketplace-n92bx-config.json",
StdErr: "unable to recognize no matches for kind "CatalogSourceConfig" in version "operators.coreos.com/v1"",
ExitError: {
ProcessState: {
pid: 4370,
status: 256,
rusage: {
Utime: {Sec: 0, Usec: 285995},
Stime: {Sec: 0, Usec: 188884},
Maxrss: 130704,
Ixrss: 0,
Idrss: 0,
Isrss: 0,
Minflt: 13211,
Majflt: 0,
Nswap: 0,
Inblock: 0,
Oublock: 1808,
Msgsnd: 0,
Msgrcv: 0,
Nsignals: 0,
Nvcsw: 2050,
Nivcsw: 41,
},
},
Stderr: nil,
},
}
exit status 1
occurred

@awgreene
Copy link
Member Author

awgreene commented Dec 4, 2019

/retest

level=fatal msg="failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform"

@awgreene
Copy link
Member Author

awgreene commented Dec 4, 2019

/retest

2 similar comments
@awgreene
Copy link
Member Author

awgreene commented Dec 5, 2019

/retest

@shawn-hurley
Copy link
Member

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@awgreene
Copy link
Member Author

awgreene commented Dec 5, 2019

/retest

@awgreene
Implement Structural Schema
1e75d07 
oc explain (and kubectl explain) both broken on Kubernetes version 1.16
due to the release of v1 CRDs. V1 CRDs require a structural schema for oc
explain to work.

This commit uses the `operator-sdk generate` command to introduce a
structural schema.
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit a43a232 into operator-framework:master Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

@awgreene: All pull requests linked via external trackers have merged. Bugzilla bug 1771277 has been moved to the MODIFIED state.

In response to this:

Bug 1771277: Implement Structural Schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpeeler
Copy link
Contributor

jpeeler commented Dec 5, 2019

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2019
Merged
@openshift-cherrypick-robot
Copy link

@jpeeler: new pull request created: #275

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@ecordell ecordell

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@awgreene @kevinrizza @openshift-ci-robot @ecordell @shawn-hurley @jpeeler @openshift-cherrypick-robot @openshift-merge-robot