Bug 1788670: Use DNS for CatalogSource address #277
Conversation
openshift-ci-robot
added
approved
kevinrizza
force-pushed
the
use-dns-for-catsrc-address
branch
from
e6ee800
to
ecb144e
Compare
openshift-ci-robot
added
size/S
|
/cc @njhale |
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
pkg/grpccatalog/grpccatalog.go
Outdated
| @@ -108,6 +112,19 @@ func (r *GrpcCatalog) EnsureResources(key types.NamespacedName, displayName, pub | |||
| return nil | |||
| } | |||
|
|
|||
| func setTimestampLabel(catsrc *olm.CatalogSource) { | |||
There was a problem hiding this comment.
not 100% sure this is necessary, since we watch events on the GRPC connection and resync the catalogsource if the connection state changes.
The grpc connection can't live through a pod rollout but this seems like a reasonable safeguard in case some events are missed / issues with the grpc conection watch.
|
/lgtm |
Problem: Marketplace needs to support ipv6 clusters. Currently when creating catalogsources, the marketplace points the catsrc to the clusterIP address of the registry pod that it spins up. This cluster ip will not work in an ipv6 only cluster. Solution: Use the dns address of the service to wire up the catalogsource to the registry pod.
kevinrizza
force-pushed
the
use-dns-for-catsrc-address
branch
from
ecb144e
to
23ac981
Compare
openshift-ci-robot
added
size/XS
|
/test e2e-aws-operator |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ecordell
changed the title
|
@kevinrizza: All pull requests linked via external trackers have merged. Bugzilla bug 1788670 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@ecordell: new pull request created: #285 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem:
Marketplace needs to support ipv6 clusters. Currently when creating
catalogsources, the marketplace points the catsrc to the clusterIP
address of the registry pod that it spins up. This cluster ip will not
work in an ipv6 only cluster.
Solution:
Use the dns address of the service to wire up the catalogsource to the
registry pod.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs