Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[migration] Remove OCP 4.1 -> 4.2 migrator #291

Merged
merged 2 commits into from Mar 16, 2020
Merged

[migration] Remove OCP 4.1 -> 4.2 migrator #291

merged 2 commits into from Mar 16, 2020

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Mar 16, 2020

Description of the change:

This PR removes the migrator introduced in OCP 4.2 to handle
resources during 4.1 -> 4.2 cluster upgrade.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@anik120
[migration] Remove OCP 4.1 -> 4.2 migrator
cc83832 
This PR removes the migrator introduced in OCP 4.2 to handle
resources during 4.1 -> 4.2 cluster upgrade.
@anik120
[dep] Remove dependency on k8s.io/kubernetes
b32255f 
Dependency was introduced to handle labeling of subscription
objects during migration from OCP 4.1 -> 4.2, which is no
longer needed.
@anik120
Copy link
Contributor Author

anik120 commented Mar 16, 2020

Ref: #223

@kevinrizza
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@anik120
Copy link
Contributor Author

anik120 commented Mar 16, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 82a75d7 into operator-framework:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp Awaiting requested review from aravindhp

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anik120 @kevinrizza @openshift-ci-robot @openshift-bot @openshift-merge-robot